Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EndpointSlice #1172

Closed
mflendrich opened this issue Apr 9, 2021 · 5 comments
Closed

Support EndpointSlice #1172

mflendrich opened this issue Apr 9, 2021 · 5 comments
Labels
area/feature New feature or request

Comments

@mflendrich
Copy link
Contributor

mflendrich commented Apr 9, 2021

In Kubernetes 1.21 (release notes, KEP), EndpointSlice graduated to GA (GV: discovery.k8s.io/v1), as a replacement for core/v1 Endpoint.

This means that KIC can use the following APIs to watch service endpoints:

  • core/v1 Endpoint: all versions, with limitations, likely deprecated in the future
  • discovery.k8s.io/v1beta1: k8s 1.18-1.24 (in 1.17 behind a feature gate)
  • discovery.k8s.io/v1: k8s 1.21+
@shaneutt
Copy link
Contributor

Closing as stale, if anyone is still in need of this support please feel free to comment here with your use cases and we'll be happy to re-open and re-assess.

@seh
Copy link
Contributor

seh commented Mar 22, 2022

Does that mean that Kong still does not support EndpointSlice?

@shaneutt
Copy link
Contributor

shaneutt commented Mar 22, 2022

That's correct today, but this being closed does not mean it's dead it just means it's not an active priority at this very moment. It will be our intention to open this again (or possibly create a new issue) when this becomes a technical blocker or requirement, or sooner if there's a strong need expressed by end-users.

@rainest
Copy link
Contributor

rainest commented Apr 5, 2023

Reopening this as an overly aggressive stale close. We had clear interest in this based on the earlier PRs and comments here, and got another from @pgold30 with new info as of 1.22, where this is more of a requirement with the endpoint cap.


Discussed in Kong/kong#10616

Originally posted by pgold30 April 5, 2023
Description:
EndpointSlice is now enabled by default in Kubernetes and offers some solid performance benefits for clusters with large Endpoint sets. It might be worthwhile to support consuming EndpointSlice, at least as optional.

Envoy is designed for scale and the use case for endpointslice also.

The lack of EndpointSlices implementation is unfortunately impacting production for us now. Since Kubernetes v1.22, Services that exceed 1000 Pods/network endpoints, Endpoints are now being truncated to a maximum of 1000 items.
Im sure thttps://github.com/kubernetes/ingress-nginx/issues/6017#issuecomment-1170285796 are many other people with the same issue. (same here in Countour)

Outlining the pieces needed to implement this issue @arkodg pointed envoyproxy/gateway#35 (comment)

[Relevant Links:]
projectcontour/contour#2696.
This was shortly discussed envoyproxy/gateway#35 and envoyproxy/gateway#35 (comment)
This was fixed on Feb 15 for nginx-ingress kubernetes/ingress-nginx#8890

@mflendrich
Copy link
Contributor Author

Superseded by #3916

@mflendrich mflendrich closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants