-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
response-ratelimiting plugin appears broken in 0.5.3 #734
Comments
This is weird since we didn't change anything in the response rate-limiting plugin in 0.5.3: 0.5.2...0.5.3 Do the error logs show anything weird? Maybe Cassandra is not incrementing the counters, thus they always remain the same? |
Not sure what this means. In any case, I will check a fresh auto-deployed system for the same symptom tomorrow. |
It appears that in log.lua line 7, the :increment function on the DAO returns an error. Unfortunately the error is not a string but a table (like all DAO errors), hence, the ngx.log function cannot log it. One needs to execute |
I re-deployed the AMI and it's fine. Sorry for the false alarm! |
I've got two instances of Kong running, 0.5.2 and 0.5.3, both spun up identically via the official AWS AMI.
The response-ratelimiting plugin works correctly in 0.5.2.
In 0.5.3, the X-RateLimit-Remaining header does not decrement (from the perspective from the API consumer) and the API is never limited.
Perhaps 0.5.3 requires different configuration than 0.5.2? Perhaps the cassandra connection is messed up and the plugin usage statefulness is not getting stored?
The text was updated successfully, but these errors were encountered: