Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting "Escape" to close the "Manage Environments" modal doesn't save the new environment settings. #5937

Open
1 task done
AustinTSchaffer opened this issue May 2, 2023 · 6 comments
Labels
B-bug Bug: general classification S-verified Status: Verified by maintainer

Comments

@AustinTSchaffer
Copy link

Expected Behavior

You can hit Command+E or CTRL+E to open the "Manage Environments" model. Hitting "Escape" should close the "Manage Environments" modal, as well as save any changes that were made to the environment settings.

Actual Behavior

Currently, hitting "Escape" to close the "Manage Environments" modal only closes it and does not save the settings.

There does not appear to be a dedicated shortcut to close the modal, apart from "Escape" either. This means the only way to adjust settings is to hit "X" or "Close".

Reproduction Steps

  1. Open the "Manage Environments" modal
  2. Add a new key/value pair
  3. Hit "escape"
  4. Reopen the "Manage Environments" modal
  5. observe that the new key/value pair was not saved

Is there an existing issue for this?

Additional Information

Version: Insomnia 2023.2.0
Build date: 4/26/2023
OS: Darwin x64 22.4.0
Electron: 22.0.0
Node: 16.17.1
V8: 10.8.168.20-electron.0
Architecture: x64

Insomnia Version

2023.2.0

What operating system are you using?

macOS

Operating System Version

Darwin x64 22.4.0

Installation method

brew install --cask insomnia

Last Known Working Insomnia version

N/A

@AustinTSchaffer AustinTSchaffer added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels May 2, 2023
@filfreire filfreire added S-verified Status: Verified by maintainer and removed S-unverified Status: Unverified by maintainer labels May 5, 2023
@filfreire
Copy link
Member

Thanks for reporting this @AustinTSchaffer - I can also reproduce, we'll try to fix this in time for the next patch release 👍

@AustinTSchaffer
Copy link
Author

Thanks @filfreire!

@perttuzp10
Copy link

I'm on the below version, still cannot save environments.

Version: Insomnia 2023.5.8
Build date: 9/7/2023
OS: Darwin x64 22.6.0
Electron: 25.2.0
Node: 18.15.0
Node ABI: 116
V8: 11.4.183.23-electron.0
Architecture: x64

@arminio
Copy link

arminio commented Oct 5, 2023

Any updates on this?

@IvoQA
Copy link

IvoQA commented Nov 10, 2023

Reproduceable with latest version.
Really frustrating.
Workaround is to click somewhere in the opened environment window and than click escape.

Version: Insomnia 8.4.0
Build date: 11/9/2023
OS: Windows_NT x64 10.0.19044
Electron: 27.0.3
Node: 18.17.1
Node ABI: 118
V8: 11.8.172.16-electron.0
Architecture: x64

@andrea-mauro
Copy link
Contributor

andrea-mauro commented Mar 29, 2024

This seems to be resolved on the last develop version. Ticket should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification S-verified Status: Verified by maintainer
Projects
None yet
Development

No branches or pull requests

6 participants