Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CONTROLLER_DEVELOPMENT_MODE in favor of specific settings #118

Open
2 tasks
mflendrich opened this issue Mar 13, 2024 · 0 comments
Open
2 tasks

Remove CONTROLLER_DEVELOPMENT_MODE in favor of specific settings #118

mflendrich opened this issue Mar 13, 2024 · 0 comments
Labels
migrated-from-archive Issues migrated from the archived KGO repository

Comments

@mflendrich
Copy link
Contributor

Problem Statement

Using a one-size-fits-all dev mode approach violates one of the 12-factor principles https://12factor.net/dev-prod-parity and we're seeing it cause real-world problems.

Proposed Solution

  1. Get rid of the CONTROLLER_DEVELOPMENT_MODE setting in favor of specific settings for specific behaviors.
  2. Determine the minimal set of those "specific behaviors" that must be different on CI than in production and only enable those.

Additional Information

I speculate that allowing non-allowlisted image tags could move from a runtime knob to e.g. an annotation (or some other kind of config as code parameter).

Acceptance Criteria

  • CONTROLLER_DEVELOPMENT_MODE does not exist anymore
  • CI has anonymous reports disabled and everything else in dev mode enabled unless there's a well understood reason for that particular bit to be non-default
@mlavacca mlavacca added the migrated-from-archive Issues migrated from the archived KGO repository label Apr 19, 2024
@czeslavo czeslavo transferred this issue from another repository Apr 22, 2024
@czeslavo czeslavo transferred this issue from another repository Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrated-from-archive Issues migrated from the archived KGO repository
Projects
None yet
Development

No branches or pull requests

2 participants