Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: KGO konnectExtension docs #8097

Merged
merged 9 commits into from
Oct 31, 2024
Merged

feat: KGO konnectExtension docs #8097

merged 9 commits into from
Oct 31, 2024

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Oct 29, 2024 •
edited by pmalek
Loading

@mlavacca mlavacca requested review from mheap and a team October 29, 2024 09:01
@mlavacca mlavacca requested a review from a team as a code owner October 29, 2024 09:01
@mlavacca mlavacca added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Oct 29, 2024
@mlavacca mlavacca force-pushed the konnect-dataplanes-kgo branch 2 times, most recently from 030996d to 09ba59a Compare October 29, 2024 09:29
@mlavacca mlavacca added this to the KGO v1.4.x milestone Oct 29, 2024
@lena-larionova lena-larionova self-assigned this Oct 29, 2024
Base automatically changed from prepare-kgo-1.4 to main October 29, 2024 20:22
@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit cdab995
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/67237c026b6d680008057abd
😎 Deploy Preview https://deploy-preview-8097--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 93 (🟢 up 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lena-larionova
Copy link
Contributor

Rebased on main after merging #8083.

lena-larionova
lena-larionova reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor formatting/grammar edits.

app/_includes/snippets/gateway-operator/install_with_helm.md Outdated Show resolved Hide resolved
app/_src/gateway-operator/get-started/konnect/deploy-data-plane.md Outdated Show resolved Hide resolved
app/_src/gateway-operator/get-started/konnect/deploy-data-plane.md Outdated Show resolved Hide resolved
app/_src/gateway-operator/get-started/konnect/deploy-data-plane.md Outdated Show resolved Hide resolved
app/_src/gateway-operator/get-started/konnect/deploy-data-plane.md Outdated Show resolved Hide resolved
app/_src/gateway-operator/get-started/konnect/deploy-data-plane.md Outdated Show resolved Hide resolved
app/_src/gateway-operator/get-started/konnect/deploy-data-plane.md Outdated Show resolved Hide resolved
app/_src/gateway-operator/get-started/konnect/deploy-data-plane.md Outdated Show resolved Hide resolved
app/_src/gateway-operator/get-started/konnect/install.md Outdated Show resolved Hide resolved
mlavacca and others added 4 commits October 31, 2024 10:17
@mlavacca
feat: KGO konnectExtension docs
3d9f908 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca @lena-larionova
Apply suggestions from code review
a628204 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@mlavacca
remove useless sentence
907c20d 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca
address comments
775b3fb 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca requested a review from pmalek October 31, 2024 09:41
@pmalek pmalek added the team-k8s Kubernetes task tracking (including KIC,KGO) label Oct 31, 2024
@mheap mheap merged commit 1041362 into main Oct 31, 2024
15 checks passed
@mheap mheap deleted the konnect-dataplanes-kgo branch October 31, 2024 12:55
@lena-larionova lena-larionova mentioned this pull request Nov 1, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheap mheap mheap approved these changes

@pmalek pmalek pmalek approved these changes

@lena-larionova lena-larionova Awaiting requested review from lena-larionova

Assignees

@lena-larionova lena-larionova

Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? team-k8s Kubernetes task tracking (including KIC,KGO)
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.
4 participants
@mlavacca @lena-larionova @mheap @pmalek