Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-final errors on automatic refund of failed swaps #1703

Open
cipig opened this issue Mar 9, 2023 · 2 comments
Open

non-final errors on automatic refund of failed swaps #1703

cipig opened this issue Mar 9, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@cipig
Copy link
Member

cipig commented Mar 9, 2023

refunding failed ARRR swaps fails with non-final error like this

         "event" : {
            "data" : {
               "error" : "maker_swap:1165] !maker_coin.send_maker_refunds_payment: mm2src/coins/z_coin.rs:1290] z_htlc:182] rpc_clients:2185] TxRecoverable(ZTransaction(Transaction { txid: TxId([104, 235, 198, 211, 123, 229, 216, 139, 240, 124, 233, 51, 28, 218, 133, 105, 169, 189, 146, 103, 22, 177, 98, 160, 241, 43, 112, 210, 72, 162, 229, 55]), data: TransactionData(\n                version = Sapling,\n                vin = [TxIn { prevout: OutPoint { hash: [91, 160, 231, 185, 203, 185, 116, 87, 163, 42, 113, 81, 215, 59, 39, 158, 68, 144, 32, 220, 46, 182, 241, 52, 61, 91, 123, 47, 2, 168, 253, 141], n: 0 }, script_sig: Script([71, 48, 68, 2, 32, 82, 25, 44, 48, 135, 248, 161, 111, 0, 202, 88, 31, 180, 88, 187, 80, 118, 209, 39, 66, 83, 197, 184, 83, 65, 90, 146, 219, 15, 15, 124, 249, 2, 32, 20, 155, 1, 39, 99, 130, 21, 218, 125, 240, 202, 187, 29, 163, 136, 55, 213, 221, 17, 40, 190, 160, 245, 86, 16, 0, 233, 55, 156, 235, 203, 121, 1, 81, 76, 107, 99, 4, 74, 182, 7, 100, 177, 117, 33, 3, 93, 52, 15, 75, 188, 244, 241, 89, 90, 25, 235, 149, 246, 109, 142, 239, 40, 108, 151, 233, 93, 99, 244, 0, 124, 60, 129, 216, 1, 228, 22, 179, 172, 103, 130, 1, 32, 136, 169, 20, 158, 86, 124, 12, 136, 58, 96, 24, 46, 103, 211, 158, 24, 133, 68, 253, 219, 81, 14, 31, 136, 33, 2, 122, 32, 120, 219, 100, 184, 51, 124, 65, 146, 10, 218, 110, 65, 162, 78, 43, 182, 105, 7, 112, 82, 36, 78, 33, 103, 231, 202, 104, 122, 50, 64, 172, 104]), sequence: 4294967294 }],\n                vout = [],\n                lock_time = 1678227018,\n                expiry_height = BlockHeight(2303306),\n                value_balance = Amount(-69999999000),\n                shielded_spends = [],\n                shielded_outputs = [OutputDescription(cv = ExtendedPoint { u: 0x4b18597270b82fbf4647327f4140862a83451471a19ee123574f543a09f92b70, v: 0x22741d8f2feff0cd85195120f1fed8f85d698fc71b4b543d96090cf373ad186d, z: 0x5ee15cafc3d9edffd18e41cd573126e0752be929a0fbf2097af9b7a56380d2be, t1: 0x6e26dfdd28093c1a1a846b1f49d73e6761421e86ade38a7ffdaec764502683e3, t2: 0x3a5771d2b5a635760b6b365645aff8a3b1e243a79acb633401b648f96be86016 }, cmu = 0x53b7ce1d62fccb4d787fc7b3ae526b362e01775ddd2f3e28348d6e7b8b24afb3, ephemeral_key = ExtendedPoint { u: 0x032b243477c5a334e42d2c2424747806115921b0535148d37f21e865f1dba6b7, v: 0x53f2f34d0ee1b06a03c60c35f64add31aaeccd9a701e6e2b841489057bab7ed1, z: 0x16bc3346f733420e8face09e48ca2e7fa7793844de9533642ec951bd563ce86d, t1: 0x50985f028422e198cddd9a18ca9b2a72064fcc82617e0216b0e6c0cdd4b71362, t2: 0x32680974916b3107a8634ca1e72afb9402285d09e89ee179ce05d3427627910b })],\n                joinsplits = [],\n                joinsplit_pubkey = None,\n                binding_sig = Some(Signature { rbar: [42, 182, 114, 202, 219, 68, 77, 167, 111, 18, 134, 213, 215, 199, 112, 136, 134, 43, 198, 48, 85, 35, 52, 135, 66, 119, 145, 252, 34, 115, 54, 185], sbar: [0, 150, 213, 221, 8, 24, 29, 107, 243, 118, 18, 79, 157, 70, 157, 87, 92, 90, 115, 60, 97, 184, 216, 238, 69, 35, 245, 140, 237, 233, 220, 4] })) }), \"JsonRpcError { client_info: \\\"coin: ARRR\\\", request: JsonRpcRequest { jsonrpc: \\\"2.0\\\", id: \\\"67813\\\", method: \\\"blockchain.transaction.broadcast\\\", params: [String(\\\"0400008085202f89015ba0e7b9cbb97457a32a7151d73b279e449020dc2eb6f1343d5b7b2f02a8fd8d00000000b6473044022052192c3087f8a16f00ca581fb458bb5076d1274253c5b853415a92db0f0f7cf90220149b0127638215da7df0cabb1da38837d5dd1128bea0f5561000e9379cebcb7901514c6b63044ab60764b17521035d340f4bbcf4f1595a19eb95f66d8eef286c97e95d63f4007c3c81d801e416b3ac6782012088a9149e567c0c883a60182e67d39e188544fddb510e1f8821027a2078db64b8337c41920ada6e41a24e2bb669077052244e2167e7ca687a3240ac68feffffff004ab607644a252300e8c7acb3efffffff0001f710d453f96c7f6607291538f9a7d587002495957dde0248da3b6e445549f3d3b3af248b7b6e8d34283e2fdd5d77012e366b52aeb3c77f784dcbfc621dceb753400dd57dd7c04cf49672f83827e96f0a5de52b88d594f06a9539000e5c8379509c3df07f7c33b23abd527b65e0980ec5966c1a5799cd1644751918f75bde5cb67b17c2c6117fee44d8ea1eccca64938c18450cf97e8c6dc8cb960f9ae33e3a2d1102b63e12fbbe4d82cf031e73390d813944eff986c5852008a41e17e1dada44b4186ad662a6207956c56d90068a348ba7dbd1cda73c242eed4dc81244e0b78b8813e088e1b74b5c92352c5c5a1071968bee7859a5622a44de337b1d9e8463e01700903894ae1301f52fd9ba3ed5d33e69631abed9333b782ffff45b6b6471116508b2fe9ef046b57bae5ae2d227469ba45d3095b0b4e5c09ee78bd14fbea6762772993c490e49699c5a2e1b2b84e96afb4b05886ec989aa2f100cf8f628ee7026745dd6f8218894a89cce602f07947d4793489de28f3cd266b1759691137dda2b08d3f50c082dd38848a378b94cd7ee04f10ae0e1241d6eede369a6146edaf6918d6554177b49b397f48d977cf0b3b018cd040a325a6269c2d78a17d90c84162333bb0d8a86aa1078963b932b004243edcf1ba694cd3b7d5c0ffd7fd8a0ae2ae21b6cd6ead4549800a359a164a506ac56e78c208492aa6c7a4e1055d497d7c5298c2ef4a607cdca7742cba7bf6761d49d420c2d5514da610e13ee012a541a18e3fc54aa4265b9c4cc2aeb088f9ae6caf35b4b332ed536f660ad5322aaa9e1ba464949839fdb1bafc6cb751e872c50bdc40c4444b6397cc3367f4cb81e856a7b2087b7509232350c1875203a9efe14667b380f4a68ae30c4fbe29fb5c1fd9a6e172c708fee1d429a92702a76f495314a688cc9afce0696c2d5b4e727b7218023f6270c2da60b5be609a1af381980781ba72607c47a6f4a378e71786e7c3266346a027b5106c66e3e495873d9a3b58a6957cd4efbd6bd913c7e8d3a0227e8a99a2aa6bef0b58cdd9a1dab18b1d8803c069e069f68a5b3908d8134cd35533ae607c32184b46513fdb5f136fc0bbea2ea403b9b5425f5dfc44ee155f9feb6aab2db983674898dcddbb8e8874f73d99a61b9517da754a5e620bcdbebd1ec84879070249fab57d42fcafadfbd750f19eb5f16c4cc859e1393c731902bed10f19ff28a7c33fba95db3f60344e572efc8210d91337a24655b629d9877c603a538ae1b1c3ada0d31a736fb893f3e9b2fe32c9f8140c572d95829c6a1255b40b029840e22f4a933ef4442b3e2c8a679e5854ed92e4cae117f002ab672cadb444da76f1286d5d7c77088862bc63055233487427791fc227336b90096d5dd08181d6bf376124f9d469d575c5a733c61b8d8ee4523f58cede9dc04\\\")] }, error: Response(node1.chainkeeper.pro:10032, Object({\\\"code\\\": Number(1), \\\"message\\\": String(\\\"the transaction was rejected by network rules.\\\\n\\\\n64: non-final\\\\n[0400008085202f89015ba0e7b9cbb97457a32a7151d73b279e449020dc2eb6f1343d5b7b2f02a8fd8d00000000b6473044022052192c3087f8a16f00ca581fb458bb5076d1274253c5b853415a92db0f0f7cf90220149b0127638215da7df0cabb1da38837d5dd1128bea0f5561000e9379cebcb7901514c6b63044ab60764b17521035d340f4bbcf4f1595a19eb95f66d8eef286c97e95d63f4007c3c81d801e416b3ac6782012088a9149e567c0c883a60182e67d39e188544fddb510e1f8821027a2078db64b8337c41920ada6e41a24e2bb669077052244e2167e7ca687a3240ac68feffffff004ab607644a252300e8c7acb3efffffff0001f710d453f96c7f6607291538f9a7d587002495957dde0248da3b6e445549f3d3b3af248b7b6e8d34283e2fdd5d77012e366b52aeb3c77f784dcbfc621dceb753400dd57dd7c04cf49672f83827e96f0a5de52b88d594f06a9539000e5c8379509c3df07f7c33b23abd527b65e0980ec5966c1a5799cd1644751918f75bde5cb67b17c2c6117fee44d8ea1eccca64938c18450cf97e8c6dc8cb960f9ae33e3a2d1102b63e12fbbe4d82cf031e73390d813944eff986c5852008a41e17e1dada44b4186ad662a6207956c56d90068a348ba7dbd1cda73c242eed4dc81244e0b78b8813e088e1b74b5c92352c5c5a1071968bee7859a5622a44de337b1d9e8463e01700903894ae1301f52fd9ba3ed5d33e69631abed9333b782ffff45b6b6471116508b2fe9ef046b57bae5ae2d227469ba45d3095b0b4e5c09ee78bd14fbea6762772993c490e49699c5a2e1b2b84e96afb4b05886ec989aa2f100cf8f628ee7026745dd6f8218894a89cce602f07947d4793489de28f3cd266b1759691137dda2b08d3f50c082dd38848a378b94cd7ee04f10ae0e1241d6eede369a6146edaf6918d6554177b49b397f48d977cf0b3b018cd040a325a6269c2d78a17d90c84162333bb0d8a86aa1078963b932b004243edcf1ba694cd3b7d5c0ffd7fd8a0ae2ae21b6cd6ead4549800a359a164a506ac56e78c208492aa6c7a4e1055d497d7c5298c2ef4a607cdca7742cba7bf6761d49d420c2d5514da610e13ee012a541a18e3fc54aa4265b9c4cc2aeb088f9ae6caf35b4b332ed536f660ad5322aaa9e1ba464949839fdb1bafc6cb751e872c50bdc40c4444b6397cc3367f4cb81e856a7b2087b7509232350c1875203a9efe14667b380f4a68ae30c4fbe29fb5c1fd9a6e172c708fee1d429a92702a76f495314a688cc9afce0696c2d5b4e727b7218023f6270c2da60b5be609a1af381980781ba72607c47a6f4a378e71786e7c3266346a027b5106c66e3e495873d9a3b58a6957cd4efbd6bd913c7e8d3a0227e8a99a2aa6bef0b58cdd9a1dab18b1d8803c069e069f68a5b3908d8134cd35533ae607c32184b46513fdb5f136fc0bbea2ea403b9b5425f5dfc44ee155f9feb6aab2db983674898dcddbb8e8874f73d99a61b9517da754a5e620bcdbebd1ec84879070249fab57d42fcafadfbd750f19eb5f16c4cc859e1393c731902bed10f19ff28a7c33fba95db3f60344e572efc8210d91337a24655b629d9877c603a538ae1b1c3ada0d31a736fb893f3e9b2fe32c9f8140c572d95829c6a1255b40b029840e22f4a933ef4442b3e2c8a679e5854ed92e4cae117f002ab672cadb444da76f1286d5d7c77088862bc63055233487427791fc227336b90096d5dd08181d6bf376124f9d469d575c5a733c61b8d8ee4523f58cede9dc04]\\\")})) }\")"
            },
            "type" : "MakerPaymentRefundFailed"
         },
         "timestamp" : 1678227033364

from ae172f1a-c966-4052-8a5a-0d7be53ff40c
i need to regularly call recover_funds_of_swap manually at a later time to refund all those failed swaps

@shamardy shamardy added the bug Something isn't working label Mar 10, 2023
@laruh laruh self-assigned this Apr 17, 2023
@laruh
Copy link
Member

laruh commented Apr 17, 2023

will look at it when there is time

@cipig
Copy link
Member Author

cipig commented Jun 21, 2023

this sometimes happens with other coins too and is related to slow block production on the respective chains in the respective timeframe... too few blocks = non-final error on automatic recover and needs to be refunded manually later by the user
idk if there is actually a fix for this possible

@cipig cipig changed the title non-final errors on ARRR refund after failed swap non-final errors on automatic refund of failed swaps Jun 21, 2023
@shamardy shamardy assigned shamardy and unassigned laruh Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants