Confirm Replacements dialog is broken

[Defman21]

Short Summary

When you search & replace in a directory, you'll get this dialog that will you ask to confirm replacements. It's a bit broken.

If there are files without an extension, you're not able to check/uncheck them.

If there are files without an extension and no changes will be made to them, they are showing on Confirm Replacements dialog (files with extensions are hidden).

[th3coop]

Screen shot please. Pretty sure this is by design. Does it say "skipped" and "unknown Language" beside those "broken" entries?

[Defman21]

Will do. This is not by design, trust me :P

[Defman21]

See the check mark. It's under the checkbox and is always enabled.

[th3coop]

Yes unfortunately, as I said, this is by design. It was meant as a save guard to not allow editting of binary files I believe. See #467.

[Defman21]

What's the point of displaying a check mark? :)

[th3coop]

I don't know what you're talking about. You reported two issue in your original comment and they are addressed by #467. Is there another issue?

[Defman21]

Do you see a checkbox before "skipped" word? There's a check mark right behind it. I think it should not be visible in this way.

[th3coop]

Ahh, no that's supposed to be there. That's the XUL treeview indicator that the column is a checkbox column. Looks like the CSS is bad for the dialog though as the selection (if that's a selection) covers part of the checkmark. You COULD file a new bug for that but I wouldn't bother. That dialog will get an overhaul when it's UX get's fixed in #467.

Here's the same checkmark in the Publishing dialog.

[Defman21]

This one looks cool! (btw this is how the checkboxes I showed looks like where there are files where the replacement can be)

[Defman21]

[th3coop]

ya there is some weird styling going on there that's causing the check mark to get covered. I suspect that if the hello.php item was the first in the list then the checkmark at the top wouldn't be covered any more. As I said, that probably won't make it through an overhaul of the UI and UX of that dialog.