Merge pull request #76 from AD7six/feature/better-missing-error

Evgeniy Guseletov · Evgeniy Guseletov · commit ce011c3b7d23 · 2013-10-16T02:37:14.000-07:00
provide a better missing error message
diff --git a/lib/Github/HttpClient/Listener/ErrorListener.php b/lib/Github/HttpClient/Listener/ErrorListener.php
@@ -57,7 +57,7 @@ public function postSend(RequestInterface $request, MessageInterface $response)
                     foreach ($content['errors'] as $error) {
                         switch ($error['code']) {
                             case 'missing':
-                                $errors[] = sprintf('Resource "%s" not exists anymore', $error['resource']);
+                                $errors[] = sprintf('The %s %s does not exist, for resource "%s"', $error['field'], $error['value'], $error['resource']);
                                 break;
 
                             case 'missing_field':
diff --git a/test/Github/Tests/HttpClient/Listener/ErrorListenerTest.php b/test/Github/Tests/HttpClient/Listener/ErrorListenerTest.php
@@ -124,6 +124,7 @@ public function shouldNotPassWhen422IsSentWithErrorCode($errorCode)
                 array(
                     'code'     => $errorCode,
                     'field'    => 'test',
+                    'value'    => 'wrong',
                     'resource' => 'fake'
                 )
             )

Original file line number	Diff line number	Diff line change
`@@ -124,6 +124,7 @@ public function shouldNotPassWhen422IsSentWithErrorCode($errorCode)`
`124`	`124`	`array(`
`125`	`125`	`'code' => $errorCode,`
`126`	`126`	`'field' => 'test',`
	`127`	`+ 'value' => 'wrong',`
`127`	`128`	`'resource' => 'fake'`
`128`	`129`	`)`
`129`	`130`	`)`