Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an adapter factory feels wrong #121

Open
tseho opened this issue Sep 22, 2015 · 0 comments
Open

Adding an adapter factory feels wrong #121

tseho opened this issue Sep 22, 2015 · 0 comments

Comments

@tseho
Copy link

tseho commented Sep 22, 2015

In KnpGaufretteBundle/DependencyInjection/KnpGaufretteExtension.php, the createAdapterFactories() has not been updated since 8 May 2011.

This function load the services tagged with gaufrette.adapter.factory ONLY if the services are defined in KnpGaufretteBundle/Resources/config/adapter_factories.xml or are defined (for user-created adapter factories) in the bundle configuration.

Currently, it's working if we are doing this:

#app/config/config.yml
knp_gaufrette:
    factories:
        - "%kernel.root_dir%/../src/AppBundle/Resources/config/adapter_factories.xml"

So instead of looking for services with the tag gaufrette.adapter.factory in the default container, this configuration force us to specify which services configuration files to load.

It is done on purpose ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants