Skip to content
This repository has been archived by the owner on Sep 23, 2022. It is now read-only.

I can change settings of strange bundles #387

Closed
Koc opened this issue Jan 11, 2014 · 9 comments
Closed

I can change settings of strange bundles #387

Koc opened this issue Jan 11, 2014 · 9 comments
Assignees

Comments

@Koc
Copy link

Koc commented Jan 11, 2014

http://easycaptures.com/fs/uploaded/611/2369156867.jpg

@wysow
Copy link
Contributor

wysow commented Oct 24, 2014

@Koc is this still the case ?

If not we will close this issue...

@Koc
Copy link
Author

Koc commented Oct 27, 2014

This issue still occurs as before

@wysow
Copy link
Contributor

wysow commented Mar 18, 2015

@Koc not easy for me to reproduce this behavior... maybe you were part of this bundle organization on github at some point?

@wysow wysow self-assigned this Mar 18, 2015
@Koc
Copy link
Author

Koc commented Mar 18, 2015

I had commited something to this bundle a long time ago. But I'm not member of this organization.

@wysow
Copy link
Contributor

wysow commented Mar 20, 2015

@Koc I just take a look to the current data and you're not linked to that bundle in the system, is the bug still here?

@Koc
Copy link
Author

Koc commented Mar 20, 2015

@wysow
Copy link
Contributor

wysow commented Mar 20, 2015

OK @Koc as you can see here

public function isOwnerOrContributor(Owner $owner)
as soon has you contributed to the bundle you are allowed to modify it, thanks @akovalyov for letting me get this ;)

@wysow wysow closed this as completed Mar 20, 2015
@wysow wysow removed the in progress label Mar 20, 2015
@akovalyov
Copy link
Contributor

@wysow I am thinking about this issue. Maybe we should allow to modify bundle settings only to owners of the repo? It seems to be a potential root of issues.

@wysow
Copy link
Contributor

wysow commented Mar 20, 2015

@akovalyov sure you're right will try to make it ASAP

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants