Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] tmc 2209-5160 coolstep #2491

Closed
Coffee0297 opened this issue Feb 8, 2020 · 10 comments
Closed

[FEATURE REQUEST] tmc 2209-5160 coolstep #2491

Coffee0297 opened this issue Feb 8, 2020 · 10 comments

Comments

@Coffee0297
Copy link
Contributor

MarlinFirmware/Marlin#16790

Marlin just got a pull for coolstep, dont look too bad to implement in klipper. it wuld be abselutly perfect for 3d printers, wich are what klipper focus on.

-Tonny

@klipper-gitissuebot
Copy link

Hi @Coffee0297,

It did not look like there was a Klipper log file attached to this ticket. The log file has been engineered to answer common questions the Klipper developers have about the software and its environment (software version, hardware type, configuration, event timing, and hundreds of other questions).

Unfortunately, too many people have opened tickets without providing the log. That consumes developer time; time that would be better spent enhancing the software. If this ticket references an event that has occurred while running the software then the Klipper log must be attached to this ticket. Otherwise, this ticket will be automatically closed in a few days.

For information on obtaining the Klipper log file see: https://github.com/KevinOConnor/klipper/blob/master/docs/Contact.md

The log can still be attached to this ticket - just add a comment and attach the log to that comment.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@FHeilmann
Copy link
Contributor

This is already possible using SET_TMC_FIELD, just pass the appropriate field names and the values and you'll be able to set up coolstep:
e.g.

SET_TMC_FIELD STEPPER=stepper_y FIELD=seup VALUE=2

the tmc2660 and tmc5160 also allow you to set these values via the config.

Keep in mind that coolstep requires a tuned stallguard value, and that the stallguard tuning is very susceptible to things like ambient temperature, movement speed and stepper motor temperature, so getting one tune for all situations is quite tricky.

-Florian

@Coffee0297
Copy link
Contributor Author

great then it shuld not be hard to make a setting that says coolstep=true
so we shuld not do it at each controller restart
-Tonny

@thisiskeithb
Copy link

CoolStep was removed almost as quickly as it was added to Marlin, so YMMV.

@Fabi0San
Copy link

Fabi0San commented Feb 11, 2020

great then it shuld not be hard to make a setting that says coolstep=true

As Florian pointed out, it needs to be cautiously tuned to your steppers and moving mass before being enabled.

CoolStep was removed almost as quickly as it was added to Marlin, so YMMV.

The settings merged to Marlin were tuned to my setup :( I tried to warn MarlinFirmware/Marlin#16790 (comment) but that PR went in quite quickly.

@KevinOConnor
Copy link
Collaborator

FYI, I'm not aware of a way to automatically configure "coolstep". To the best of my knowledge it requires external probing hardware - there's info on doing the necessary calibration in the trinamic documentation. Should someone go through those steps, it is possible to configure Klipper with the resulting values.

-Kevin

@Fabi0San
Copy link

No one setting will fit every machine, so shipping Klipper with one-size-fits-all setting is unfortunately not possible.

It is possible though to create a procedure to automatically gather the actual SG_RESULT for a given machine at given speed ranges, and use that to tune coolstep, and stallguard. No special hardware should be required. It could be similar to the home stepper phase calibration.

Cheers,
Fabio.

@KevinOConnor
Copy link
Collaborator

It is possible though to create a procedure to automatically gather the actual SG_RESULT for a given machine at given speed ranges, and use that to tune coolstep, and stallguard. No special hardware should be required. It could be similar to the home stepper phase calibration.

Okay, thanks for the info. If a developer is interested in writing such a tuning tool that would be great.

Cheers,
-Kevin

@Fabi0San
Copy link

I have to say I'm very tempted :), I just heard about Klipper because of this thread and I'm really impressed by what you've done.
I've been chasing mathematical purity on my fast(500 mm/s) delta for a few years now, after a few months modeling everything on Mathematica it was clear to me that chasing the real time acceleration computation with a complex delta geometry(diff arm lenghts, different belt tension, etc) would require more HP than even the 32bit boads could give, and it seemed silly given all the computational power available at the host. I even dabbed at creating a protocol to efficiently transferring step timings.

All that to say I really get what you are going for, I'll learn a bit more about Klipper and may take on this and other opportunities to make it better :)

Cheers,
Fabio.

@KevinOConnor
Copy link
Collaborator

I'm going to close this ticket as it looks like the conversation has concluded. If a developer is interested in adding support feel free to open a pull request with the changes.

-Kevin

@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants