Skip to content

Commit 44446dc

Browse files
authored
During pool export flush the ARC asynchronously
This also includes removing L2 vdevs asynchronously. This commit also guarantees that spa_load_guid is unique. The zpool reguid feature introduced the spa_load_guid, which is a transient value used for runtime identification purposes in the ARC. This value is not the same as the spa's persistent pool guid. However, the value is seeded from spa_generate_load_guid() which does not check for uniqueness against the spa_load_guid from other pools. Although extremely rare, you can end up with two different pools sharing the same spa_load_guid value! So we guarantee that the value is always unique and additionally not still in use by an async arc flush task. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Allan Jude <allan@klarasystems.com> Signed-off-by: Don Brady <don.brady@klarasystems.com> Closes openzfs#16215
1 parent 2507db6 commit 44446dc

File tree

7 files changed

+325
-66
lines changed

7 files changed

+325
-66
lines changed

include/sys/arc.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,15 @@ extern "C" {
6363
(hdr)->b_psize = ((x) >> SPA_MINBLOCKSHIFT); \
6464
} while (0)
6565

66+
/* The l2size in the header is only used by L2 cache */
67+
#define HDR_SET_L2SIZE(hdr, x) do { \
68+
ASSERT(IS_P2ALIGNED((x), 1U << SPA_MINBLOCKSHIFT)); \
69+
(hdr)->b_l2size = ((x) >> SPA_MINBLOCKSHIFT); \
70+
} while (0)
71+
6672
#define HDR_GET_LSIZE(hdr) ((hdr)->b_lsize << SPA_MINBLOCKSHIFT)
6773
#define HDR_GET_PSIZE(hdr) ((hdr)->b_psize << SPA_MINBLOCKSHIFT)
74+
#define HDR_GET_L2SIZE(hdr) ((hdr)->b_l2size << SPA_MINBLOCKSHIFT)
6875

6976
typedef struct arc_buf_hdr arc_buf_hdr_t;
7077
typedef struct arc_buf arc_buf_t;
@@ -322,8 +329,10 @@ void arc_freed(spa_t *spa, const blkptr_t *bp);
322329
int arc_cached(spa_t *spa, const blkptr_t *bp);
323330

324331
void arc_flush(spa_t *spa, boolean_t retry);
332+
void arc_flush_async(spa_t *spa);
325333
void arc_tempreserve_clear(uint64_t reserve);
326334
int arc_tempreserve_space(spa_t *spa, uint64_t reserve, uint64_t txg);
335+
boolean_t arc_async_flush_guid_inuse(uint64_t load_guid);
327336

328337
uint64_t arc_all_memory(void);
329338
uint64_t arc_default_max(uint64_t min, uint64_t allmem);

include/sys/arc_impl.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -378,8 +378,8 @@ typedef struct l2arc_lb_ptr_buf {
378378
* L2ARC Internals
379379
*/
380380
typedef struct l2arc_dev {
381-
vdev_t *l2ad_vdev; /* vdev */
382-
spa_t *l2ad_spa; /* spa */
381+
vdev_t *l2ad_vdev; /* can be NULL during remove */
382+
spa_t *l2ad_spa; /* can be NULL during remove */
383383
uint64_t l2ad_hand; /* next write location */
384384
uint64_t l2ad_start; /* first addr on device */
385385
uint64_t l2ad_end; /* last addr on device */
@@ -475,8 +475,8 @@ struct arc_buf_hdr {
475475

476476
arc_buf_contents_t b_type;
477477
uint8_t b_complevel;
478-
uint8_t b_reserved1; /* used for 4 byte alignment */
479-
uint16_t b_reserved2; /* used for 4 byte alignment */
478+
uint8_t b_reserved1; /* used for 4 byte alignment */
479+
uint16_t b_l2size; /* alignment or L2-only size */
480480
arc_buf_hdr_t *b_hash_next;
481481
arc_flags_t b_flags;
482482

include/sys/spa.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,6 +1106,7 @@ extern boolean_t spa_guid_exists(uint64_t pool_guid, uint64_t device_guid);
11061106
extern char *spa_strdup(const char *);
11071107
extern void spa_strfree(char *);
11081108
extern uint64_t spa_generate_guid(spa_t *spa);
1109+
extern uint64_t spa_generate_load_guid(void);
11091110
extern void snprintf_blkptr(char *buf, size_t buflen, const blkptr_t *bp);
11101111
extern void spa_freeze(spa_t *spa);
11111112
extern int spa_change_guid(spa_t *spa, const uint64_t *guidp);

0 commit comments

Comments
 (0)