feat(vtkQuad): attend to pCoords

Author: WesleyTheGeolien

Sources/Common/DataModel/Quad/Constants.js

@@ -0,0 +1,8 @@
+export const QuadWithLineIntersectionState = {
+  NO_INTERSECTION: 0,
+  YES_INTERSECTION: 1,
+};
+
+export default {
+  QuadWithLineIntersectionState,
+};

Sources/Common/DataModel/Quad/test/testQuad.js

@@ -1,6 +1,7 @@
 import test from 'tape-catch';
 import vtkQuad from 'vtk.js/Sources/Common/DataModel/Quad';
 import vtkPoints from 'vtk.js/Sources/Common/Core/Points';
+import { QuadWithLineIntersectionState } from 'vtk.js/Sources/Common/DataModel/Quad/Constants';
 
 test('Test vtkQuad instance', (t) => {
   t.ok(vtkQuad, 'Make sure the class definition exists');
@@ -10,9 +11,6 @@ test('Test vtkQuad instance', (t) => {
 });
 
 test('Test vtkQuad intersectWithLine flat', (t) => {
-  const yesIntersection = 1;
-  const noIntersection = 0;
-
   const points = vtkPoints.newInstance();
   points.setNumberOfPoints(4);
   points.setData(Float32Array.from([0, 0, 0, 1, 0, 0, 1, 1, 0, 0, 1, 0]));
@@ -28,13 +26,19 @@ test('Test vtkQuad intersectWithLine flat', (t) => {
   const pcoords = [];
   let intersection;
   intersection = quad.intersectWithLine(p1, p2, tol, x, pcoords);
-  t.equal(intersection.intersect, noIntersection);
+  t.equal(
+    intersection.intersect,
+    QuadWithLineIntersectionState.NO_INTERSECTION
+  );
 
   // Intersect on v1
   p1 = [0, 0, 0];
   p2 = [0, 0, 1];
   intersection = quad.intersectWithLine(p1, p2, tol, x, pcoords);
-  t.equal(intersection.intersect, yesIntersection);
+  t.equal(
+    intersection.intersect,
+    QuadWithLineIntersectionState.YES_INTERSECTION
+  );
   t.equal(intersection.t, 0);
   t.deepEqual(x, p1);
   t.deepEqual(pcoords, [0, 0, 0]);
@@ -43,29 +47,39 @@ test('Test vtkQuad intersectWithLine flat', (t) => {
   p1 = [1, 1, 1];
   p2 = [1, 1, 0];
   intersection = quad.intersectWithLine(p1, p2, tol, x, pcoords);
-  t.equal(intersection.intersect, yesIntersection);
+  t.equal(
+    intersection.intersect,
+    QuadWithLineIntersectionState.YES_INTERSECTION
+  );
   t.equal(intersection.t, 1);
   t.deepEqual(x, p2);
-  t.deepEqual(pcoords, [0, 1, 0]);
+  t.deepEqual(pcoords, [1, 1, 0]);
 
   // No intersection if finite line
   p1 = [-2, 0, 0];
   p2 = [-1, 0, 0];
   intersection = quad.intersectWithLine(p1, p2, tol, x, pcoords);
-  t.equal(intersection.intersect, noIntersection);
+  t.equal(
+    intersection.intersect,
+    QuadWithLineIntersectionState.NO_INTERSECTION
+  );
 
   // Parallel to v2,v3
   p1 = [2, 0, 0];
   p2 = [2, 1, 0];
   intersection = quad.intersectWithLine(p1, p2, tol, x, pcoords);
-  t.equal(intersection.intersect, noIntersection);
+  t.equal(
+    intersection.intersect,
+    QuadWithLineIntersectionState.NO_INTERSECTION
+  );
 
   // Line coplanar to quad
   p1 = [0.5, -1, 0];
   p2 = [0.5, 1, 0];
   intersection = quad.intersectWithLine(p1, p2, tol, x, pcoords);
-  t.equal(intersection.intersect, noIntersection);
-  t.equal(intersection.t, Number.MAX_VALUE);
-  t.deepEqual(pcoords, [0, 0, 0]);
+  t.equal(
+    intersection.intersect,
+    QuadWithLineIntersectionState.NO_INTERSECTION
+  );
   t.end();
 });