Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTK serialization #3

Open
9 of 11 tasks
jourdain opened this issue Apr 19, 2024 · 5 comments
Open
9 of 11 tasks

VTK serialization #3

jourdain opened this issue Apr 19, 2024 · 5 comments
Assignees

Comments

@jourdain
Copy link
Collaborator

jourdain commented Apr 19, 2024

  • ./example/pyvista/basic.py
    • vtkCoordinate
  • ./example/pyvista/bg_image.py
    • vtkImageActor
  • ./examples/pyvista/labels.py
    • vtkLabelPlacementMapper
  • ./examples/pyvista/texture.py
    • vtkOpenGLTexture
  • ./examples/pyvista/linked_view.py
    • Missing text in WASM
  • ./example/pyvista/eye_dome_lighting.py
    • vtkEDLShading
  • ./examples/vtk/charts_scatter.py
    • vtkContextInteractorStyle
    • vtkOpenGLContextActor
  • ./examples/vtk/silhouette.py
    • local interactor not picking up camera update
  • ./examples/vtk/widgets_*.py
    • no widget interaction
    • Some rep missing
  • ./examples/pyvista/pbr.py
    • vtkOpenGLSkybox

Future

  • vtkSliderRepresentation2D
  • vtk charts
@jspanchu jspanchu self-assigned this May 2, 2024
@jourdain
Copy link
Collaborator Author

jourdain commented May 2, 2024

@jspanchu I've added I think most of the examples we care about. Ideally we can make most of them works with WASM.

@jspanchu
Copy link
Member

jspanchu commented May 8, 2024

  • ./examples/vtk/silhouette.py
    local interactor not picking up camera update

So, there is another issue with silhouette where if you dragged the slider and changed the resolution of the cone, the silhouette on the client was not correct. this is fixed by https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11113

Other than that, it also needs to synchronize the local camera with server side camera. this was discussed in #4

@jspanchu
Copy link
Member

jspanchu commented May 8, 2024

I'm unable to get any of the pyvista examples running when I use developer VTK (not from pip install). Any pointers?

python examples/pyvista/basic.py --server
Traceback (most recent call last):
  File "examples/pyvista/basic.py", line 57, in <module>
    app = TrameApp()
  File "examples/pyvista/basic.py", line 34, in __init__
    self.render_window = setup_pyvista()
  File "examples/pyvista/basic.py", line 17, in setup_pyvista
    mesh = examples.download_st_helens()
  File "/home/local/KHQ/jaswant.panchumarti/dev/trame-vtklocal/.venv/lib/python3.8/site-packages/pyvista/examples/downloads.py", line 425, in download_st_helens
    return _download_and_read('SainteHelens.dem', load=load)
  File "/home/local/KHQ/jaswant.panchumarti/dev/trame-vtklocal/.venv/lib/python3.8/site-packages/pyvista/examples/downloads.py", line 260, in _download_and_read
    return read(saved_file, file_format=file_format)
  File "/home/local/KHQ/jaswant.panchumarti/dev/trame-vtklocal/.venv/lib/python3.8/site-packages/pyvista/core/utilities/fileio.py", line 201, in read
    mesh = reader.read()
  File "/home/local/KHQ/jaswant.panchumarti/dev/trame-vtklocal/.venv/lib/python3.8/site-packages/pyvista/core/utilities/reader.py", line 387, in read
    data._restore_metadata()
  File "/home/local/KHQ/jaswant.panchumarti/dev/trame-vtklocal/.venv/lib/python3.8/site-packages/pyvista/core/dataobject.py", line 192, in _restore_metadata
    if key in fdata:
TypeError: argument of type 'vtkmodules.vtkCommonDataModel.vtkFieldData' is not iterable

@jspanchu
Copy link
Member

jspanchu commented May 8, 2024

Sorted it out by using pyvista/pyvista#5650

@jspanchu
Copy link
Member

I've updated the description to reflect what's currently working and what isn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants