Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Screen Image Link Invalid #1434

Open
mattdawkins opened this issue Jul 5, 2024 · 5 comments
Open

Login Screen Image Link Invalid #1434

mattdawkins opened this issue Jul 5, 2024 · 5 comments
Labels
Type: bug Something isn't working

Comments

@mattdawkins
Copy link
Member

Looks like at some point the login image/icon became invalid

https://viame.kitware.com/static/viame/img/logo.22a6f4a3.png

leading to the below

Screenshot at 2024-07-05 12-40-38

@mattdawkins mattdawkins added the Type: bug Something isn't working label Jul 5, 2024
@BryonLewis
Copy link
Collaborator

This should be resolved.
I completely forgot but our logo is configured using the endpoint for 'brand_data' which allows us to point to any image for the URL src of logo. I don't remember why we did this. But I should probably change it so the image is in a public location on github or on the server in a URL location. It was pointing instead of a built artificat from the client process.

@waxlamp
Copy link
Member

waxlamp commented Jul 11, 2024

I assume we did it so that different orgs can custom-brand their DIVE deployments, right? How are we doing that for Terpsi?

@BryonLewis
Copy link
Collaborator

Yeah we did it for that. I'm just curious as to why it seems to be set to an internal build artifact of the client application that is transferred to the /static/viame folder during the docker build. It may make more sense as a public GirderItem URL that is referenced instead.

@waxlamp
Copy link
Member

waxlamp commented Jul 11, 2024

Oh I see what you mean. Thanks.

@BryonLewis
Copy link
Collaborator

I created a 'Branding' Collection on the server with the VIAME Developers group (us) given access. Inside is a Branding Image folder and the logo image is inside. The image src is now pointed to that file. I believe that using a client build artifact was just a remnant of before the branding system was implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants