Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeWrongOnInput doesn't track the changes in <select> just in <input> #85

Open
imeckr opened this issue Nov 24, 2019 · 1 comment
Open

Comments

@imeckr
Copy link

imeckr commented Nov 24, 2019

The current implementation of removeWrongOnInput only listens to changes in <input> but not in <select>. I know the name is explicitly mentions inputs not select, but shouldn't that be the case as they are also kind of input?

MStepper.addMultipleEventListeners(inputs, 'input', removeWrongOnInput);

@Kinark
Copy link
Owner

Kinark commented Nov 24, 2019

Yep, it definitely should be listening for select changes as well. Gonna fix it ;)

Or you can help me by submitting a PR to the develop branch :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants