Skip to content

Commit 9fbab31

Browse files
ceoyTim Jahn
andauthored
make firebase-admin an optional dependency (jazzband#707)
Co-authored-by: Tim Jahn <tim@smartfactory.ch>
1 parent 307a1b8 commit 9fbab31

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

docs/FCM.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Initialize the firebase admin in your ``settings.py`` file.
1818
.. code-block:: python
1919
2020
# Import the firebase service
21-
from firebase_admin import auth
21+
import firebase_admin
2222
2323
# Initialize the default app
2424
default_app = firebase_admin.initialize_app()

push_notifications/models.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
from django.db import models
22
from django.utils.translation import gettext_lazy as _
3-
from firebase_admin import messaging
43

54
from .fields import HexIntegerField
6-
from .gcm import dict_to_fcm_message
75
from .settings import PUSH_NOTIFICATIONS_SETTINGS as SETTINGS
86

97

@@ -60,6 +58,9 @@ def get_queryset(self):
6058
class GCMDeviceQuerySet(models.query.QuerySet):
6159
def send_message(self, message, **kwargs):
6260
if self.exists():
61+
from firebase_admin import messaging
62+
63+
from .gcm import dict_to_fcm_message
6364
from .gcm import send_message as fcm_send_message
6465

6566
if not isinstance(message, messaging.Message):
@@ -108,6 +109,9 @@ class Meta:
108109
verbose_name = _("FCM device")
109110

110111
def send_message(self, message, **kwargs):
112+
from firebase_admin import messaging
113+
114+
from .gcm import dict_to_fcm_message
111115
from .gcm import send_message as fcm_send_message
112116

113117
# GCM is not supported.
@@ -137,7 +141,7 @@ def send_message(self, message, creds=None, **kwargs):
137141
if self.exists():
138142
from .apns import apns_send_bulk_message
139143

140-
app_ids = self.filter(active=True).order_by("application_id")\
144+
app_ids = self.filter(active=True).order_by("application_id") \
141145
.values_list("application_id", flat=True).distinct()
142146
res = []
143147
for app_id in app_ids:

0 commit comments

Comments
 (0)