Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 01526 message when sampleLocationsPerPixel is 0 #8680

Open
ziga-lunarg opened this issue Oct 10, 2024 · 4 comments
Open

Improve 01526 message when sampleLocationsPerPixel is 0 #8680

ziga-lunarg opened this issue Oct 10, 2024 · 4 comments
Assignees
Labels
Enhancement New feature or request

Comments

@ziga-lunarg
Copy link
Contributor

If VkSampleLocationsInfoEXT::sampleLocationsPerPixel is 0, the validation layers message will say Unhandled VkSampleCountFlagBits

Full message is:

vkCmdSetSampleLocationsEXT(): pSampleLocationsInfo->sampleLocationsPerPixel is Unhandled VkSampleCountFlagBits, but VkPhysicalDeviceSampleLocationsPropertiesEXT::sampleLocationSampleCounts is VK_SAMPLE_COUNT_1_BIT|VK_SAMPLE_COUNT_2_BIT|VK_SAMPLE_COUNT_4_BIT|VK_SAMPLE_COUNT_8_BIT|VK_SAMPLE_COUNT_16_BIT.

@spencer-lunarg
Copy link
Contributor

so zero is not a valid VkSampleCountFlagBits so what would you prefer?

pSampleLocationsInfo->sampleLocationsPerPixel is Unhandled VkSampleCountFlagBits (0x0bad), but

@spencer-lunarg spencer-lunarg self-assigned this Oct 10, 2024
@spencer-lunarg spencer-lunarg added the Enhancement New feature or request label Oct 10, 2024
@ziga-lunarg
Copy link
Contributor Author

Yes, I would prefer to see the invalid value, rather than Unhandled VkSampleCountFlagBits.

@spencer-lunarg
Copy link
Contributor

ok, that is fair, will get a fix up soon-ish

@spencer-lunarg
Copy link
Contributor

so this is something we need to fix in VUL then, vk_enum_string_helper.h has string_VkSampleCountFlagBits which is printing Unhandled VkSampleCountFlagBits and would need to where we would print the value when using an Unhandled value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants