Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing deprecation of old device selector interface #290

Open
mkinsner opened this issue Oct 3, 2022 · 1 comment
Open

Missing deprecation of old device selector interface #290

mkinsner opened this issue Oct 3, 2022 · 1 comment

Comments

@mkinsner
Copy link

mkinsner commented Oct 3, 2022

SYCL 2020 added a new callable device selector, and contains the non-normative note:

In SYCL 1.2.1 the predefined device selectors were actually types that had to be instantiated to be used. Now they are just instances. To simplify porting code using the old type instantiations, a backward-compatible API is still provided, such as sycl::default_selector. The new predefined device selectors have their new names appended with "_v" to avoid conflicts, thus following the naming style used by traits in the C++ standard library. There is no requirement for the implementation to have for example sycl::gpu_selector_v being an instance of sycl::gpu_selector.

Since there is a new form, and the old form isn't actually defined in SYCL2020, it seems odd that the old form hasn't been marked as deprecated. Is there a reason for lack of deprecation, or is this a spec bug?

@mkinsner mkinsner added the Agenda To be discussed during a SYCL committee meeting label Oct 3, 2022
@tomdeakin
Copy link
Contributor

22/11/24: likely missing the deprecation as SYCL 2020 clarification. Please prepare PR.

@keryell keryell removed the Agenda To be discussed during a SYCL committee meeting label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants