Add llvm.abs.i32 translation #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Sep 30, 2020
I think this implementation is able to handle any type, not just i32. |
I think so too; it would be good to test another type (e.g. @MochalovaAn, there is a spurious merge commit in this pull request too. When you update the change, could you remove that and rebase on the latest master branch? |
AlexeySotkin
reviewed
Oct 2, 2020
Add llvm.abs.i32 translation to "s_abs" instruction. Add test for this. Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
AlexeySotkin
reviewed
Oct 6, 2020
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
vmaksimo
pushed a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 1, 2022
* Add llvm.abs.i32 intrinsic translation Add translation of @llvm.abs.* to `s_abs` extended instruction. Signed-off-by: amochalo <anastasiya.mochalova@intel.com> Change-Id: I789fc9902eaec18b781da2965976a36f593cad1a Reviewed-on: https://git-amr-2.devtools.intel.com/gerrit/275911 Reviewed-by: Sotkin, Alexey <alexey.sotkin@intel.com> Tested-by: Sotkin, Alexey <alexey.sotkin@intel.com> Reviewed-by: Pengfei Wang <pengfei.wang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add llvm.abs.i32 translation to "s_abs" instruction.
Add test for this.