Skip to content

Commit 3335c25

Browse files
authored
[NFC] Remove ExecutionModeNamedBarrierCountINTEL from spirv_internal (#1604)
It was actually upstreamed to SPIR-V Headers already. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
1 parent 21c7a30 commit 3335c25

File tree

6 files changed

+6
-11
lines changed

6 files changed

+6
-11
lines changed

lib/SPIRV/PreprocessMetadata.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ void PreprocessMetadataBase::preprocessVectorComputeMetadata(Module *M,
356356
.getAsInteger(0, NBarrierCnt);
357357
EM.addOp()
358358
.add(&F)
359-
.add(spv::internal::ExecutionModeNamedBarrierCountINTEL)
359+
.add(spv::ExecutionModeNamedBarrierCountINTEL)
360360
.add(NBarrierCnt)
361361
.done();
362362
}

lib/SPIRV/SPIRVReader.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4215,8 +4215,7 @@ bool SPIRVToLLVM::transVectorComputeMetadata(SPIRVFunction *BF) {
42154215
F->addFnAttr(Attr);
42164216
}
42174217

4218-
if (auto *EM =
4219-
BF->getExecutionMode(internal::ExecutionModeNamedBarrierCountINTEL)) {
4218+
if (auto *EM = BF->getExecutionMode(ExecutionModeNamedBarrierCountINTEL)) {
42204219
unsigned int NBarrierCnt = EM->getLiterals()[0];
42214220
Attribute Attr = Attribute::get(*Context, kVCMetadata::VCNamedBarrierCount,
42224221
std::to_string(NBarrierCnt));

lib/SPIRV/SPIRVWriter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4560,7 +4560,7 @@ bool LLVMToSPIRVBase::transExecutionMode() {
45604560
break;
45614561
AddSingleArgExecutionMode(static_cast<ExecutionMode>(EMode));
45624562
} break;
4563-
case spv::internal::ExecutionModeNamedBarrierCountINTEL: {
4563+
case spv::ExecutionModeNamedBarrierCountINTEL: {
45644564
if (!BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_vector_compute))
45654565
break;
45664566
unsigned NBarrierCnt = 0;

lib/SPIRV/libSPIRV/SPIRVEntry.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ void SPIRVExecutionMode::decode(std::istream &I) {
582582
case ExecutionModeFloatingPointModeALTINTEL:
583583
case ExecutionModeFloatingPointModeIEEEINTEL:
584584
case ExecutionModeSharedLocalMemorySizeINTEL:
585-
case internal::ExecutionModeNamedBarrierCountINTEL:
585+
case ExecutionModeNamedBarrierCountINTEL:
586586
case ExecutionModeSubgroupSize:
587587
case ExecutionModeMaxWorkDimINTEL:
588588
case ExecutionModeNumSIMDWorkitemsINTEL:

lib/SPIRV/libSPIRV/SPIRVEnum.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ template <> inline void SPIRVMap<SPIRVExecutionModeKind, SPIRVCapVec>::init() {
263263
{internal::CapabilityFastCompositeINTEL});
264264
ADD_VEC_INIT(internal::ExecutionModeStreamingInterfaceINTEL,
265265
{CapabilityFPGAKernelAttributesINTEL});
266-
ADD_VEC_INIT(internal::ExecutionModeNamedBarrierCountINTEL,
266+
ADD_VEC_INIT(ExecutionModeNamedBarrierCountINTEL,
267267
{CapabilityVectorComputeINTEL});
268268
}
269269

lib/SPIRV/libSPIRV/spirv_internal.hpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,7 @@ enum InternalFunctionControlMask { IFunctionControlOptNoneINTELMask = 0x10000 };
8383

8484
enum InternalExecutionMode {
8585
IExecModeFastCompositeKernelINTEL = 6088,
86-
IExecModeStreamingInterfaceINTEL = 6154,
87-
IExecModeNamedBarrierCountINTEL = 6417
86+
IExecModeStreamingInterfaceINTEL = 6154
8887
};
8988

9089
enum InternalLoopControlMask { ILoopControlLoopCountINTELMask = 0x1000000 };
@@ -179,9 +178,6 @@ constexpr ExecutionMode ExecutionModeFastCompositeKernelINTEL =
179178
constexpr ExecutionMode ExecutionModeStreamingInterfaceINTEL =
180179
static_cast<ExecutionMode>(IExecModeStreamingInterfaceINTEL);
181180

182-
constexpr ExecutionMode ExecutionModeNamedBarrierCountINTEL =
183-
static_cast<ExecutionMode>(IExecModeNamedBarrierCountINTEL);
184-
185181
static const LoopControlMask LoopControlLoopCountINTELMask =
186182
static_cast<LoopControlMask>(ILoopControlLoopCountINTELMask);
187183

0 commit comments

Comments
 (0)