Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS numbers without units where units are necessary should cause a warning #418

Open
kevinbarabash opened this issue Sep 8, 2015 · 3 comments

Comments

@kevinbarabash
Copy link
Contributor

In this case top and left should have units after their values.

#greeting { 
background: rgb(255, 255, 0); 
border: 2px solid black; 
font-family: "Comic Sans MS", fantasy; 
padding: 5px; 
width: 262px; 
position: absolute; 
top: 100; 
left: 20; 
z-index: 2; 
} 
@pamelafox
Copy link
Collaborator

I think causing a gutter warning is fine/helpful - Chrome does that sort of thing in the dev tools ("invalid property value") - but an error seems too aggressive in this case.

@kevinbarabash kevinbarabash changed the title CSS numbers without units where units are necessary should cause and error CSS numbers without units where units are necessary should cause a warning Sep 9, 2015
@kevinbarabash
Copy link
Contributor Author

@pamelafox sounds good.

@jjwon0
Copy link
Contributor

jjwon0 commented Sep 11, 2015

seems there'd be append a lot of information to slowparse to make it validate css. right now, slowparse is more structural.

we could consider integrating csslint into live-editor as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants