Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification of TunablePrecision parameters only work if using the AccuracyObserver #245

Open
isazi opened this issue Mar 1, 2024 · 0 comments
Assignees
Labels

Comments

@isazi
Copy link
Collaborator

isazi commented Mar 1, 2024

Hi @stijnh I assigned this to you to check if this is a bug or a feature :)

In practice if you only want to use the TunablePrecision types to test the performance of various types of floats, and are not interested in measuring the loss of accuracy with the AccuracyObserver the verification does not work anymore.

Simple test, using the accuracy.py example in examples/cuda, just remove the observers and you get this error:

TypeError: Element 3 of the expected results list is not of the same dtype as the kernel output: float64 != float32.

If the observers are passed to tune_kernel, then everything works.

@isazi isazi added the bug label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants