[Bugfix] init PasteReference with internal promise, to get most recent clipboard data (#79),

[Bugfix] correct comment markers in paste_reference-drag-drop.js

Author: DavidBruchmann

Resources/Public/JavaScript/paste-reference-drag-drop.js

@@ -44,7 +44,6 @@ DragDrop.default = {
 
   /**
    * initializes Drag+Drop for all content elements on the page
-   */
   initialize: function () {
     (DragDrop.default.draggableIdentifier).draggable({
       handle: this.draggableContentHandle,
@@ -80,6 +79,7 @@ DragDrop.default = {
       draggableElement: draggableElement
     };
   },
+   */
 
   /**
    * this method does the whole logic when a draggable is dropped
@@ -158,10 +158,12 @@ DragDrop.default = {
       if (typeof foundTarget === 'undefined') {
         targetPid = draggable.getPid();
         sorting = 0;
-        // console.log('Setting sorting=0 for first element in container column:', {
+        /*
+        console.log('Setting sorting=0 for first element in container column:', {
           colPos: colPos,
           txContainerParent: txContainerParent,
         });
+        */
       } else {
         // the negative value of the content element after where it should be moved
         targetPid = 0 - parseInt(foundTarget);
@@ -403,6 +405,7 @@ console.log(draggable);
             }
           }
         }
+        /*
         if (parameters.basicAction == 'copy' || parameters.basicAction == 'move') {
           thisClass.broadcast('elementChanged', {
             pid: draggableElement.pid,
@@ -411,6 +414,7 @@ console.log(draggable);
             action: parameters.basicAction
           });
         }
+        */
         self.location.hash = droppableElement.closest(DragDrop.default.contentIdentifier).id;
         /*
         console.log(parameters.basicAction,{

Resources/Public/JavaScript/paste-reference.js

@@ -45,17 +45,23 @@ class PasteReference {
     this.copyMode = args.copyMode;
     DocumentService.ready().then(() => {
       if (document.querySelectorAll('.t3js-page-columns').length > 0) {
-        this.getClipboardData();
-        this.generateButtonTemplates();
-        this.activatePasteIcons();
-        this.initializeEvents();
-        this.initModalEventListener();
+        // promise to assure that most recent data are used
+        this.getClipboardData()
+          .then(() => {
+            this.generateButtonTemplates();
+            this.activatePasteIcons();
+            this.initializeEvents();
+            this.initModalEventListener();
+          })
+          .catch((err) => {
+            console.error('Error initializing PasteReference:', err);
+          });
       }
     });
   }
 
   getClipboardData() {
-    (new AjaxRequest(top.TYPO3.settings.Clipboard.moduleUrl))
+    return (new AjaxRequest(top.TYPO3.settings.Clipboard.moduleUrl))
       .withQueryArguments({ action: 'getClipboardData' })
       .post({ table: 'tt_content' })
       .then(async (response) => {
@@ -73,6 +79,9 @@ class PasteReference {
           this.itemOnClipboardTitleHtml = record ? record.title : '';
           this.itemOnClipboardTable = table;
         }
+        else {
+          console.error('Error: ClipboardData couldn\'t be retieved.');
+        };
       });
   }
 
@@ -112,7 +121,8 @@ class PasteReference {
           resolve(elementAbove.querySelector(selector));
         }
       });
-      // If you get "parameter 1 is not of type 'Node'" error, see https://stackoverflow.com/a/77855838/492336
+      // If you get "parameter 1 is not of type 'Node'" error,
+      // see https://stackoverflow.com/a/77855838/492336
       observer.observe(document.body, {
         childList: true,
         subtree: true
@@ -215,7 +225,7 @@ class PasteReference {
                 .setPid(page)
                 .setColpos(colpos)
                 .setUid(tableUid);
-              
+
               if (txContainerParent > 0) {
                 draggableObj.setTxContainerParent(txContainerParent);
               }
@@ -255,9 +265,12 @@ class PasteReference {
       + ' title="' + TYPO3.lang['tx_paste_reference_js.copyfrompage'] + '">'
       + '<typo3-backend-icon identifier="actions-insert-reference" size="small"></typo3-backend-icon>'
       + '</button>';
+    /*
+    // might removal fix issue #79?
     if (!this.itemOnClipboardUid) {
       return;
     }
+    */
     this.pasteAfterLinkTemplate = '<button'
       + ' type="button"'
       + ' class="t3js-paste t3js-paste' + (this.copyMode ? '-' + this.copyMode : '') + ' t3js-paste-after btn btn-default btn-sm"'
@@ -570,12 +583,3 @@ class PasteReference {
 }
 
 export default PasteReference;
-
-if (!PasteReference.instance && top.pasteReferenceAllowed) {
-  const pollTime = 100;
-  window.setTimeout(function() {
-    if (!PasteReference.instance) {
-      const pasteReference = new PasteReference({});
-    }
-  }, pollTime);
-}