Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to update endpoints #94

Closed
ilazakis opened this issue Jul 10, 2019 · 4 comments
Closed

Add ability to update endpoints #94

ilazakis opened this issue Jul 10, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ilazakis
Copy link
Contributor

What
Ability (new command or probably better an update option on the existing deploy command) to update an endpoint’s configuration. As of today, if we deploy an endpoint there’s no way of amending its configuration e.g. instance type.

Running deploy using different params and the same endpoint name does not work unfortunately, SageMaker throws a duplicate endpoint exception.

@ilazakis ilazakis added the enhancement New feature or request label Jul 10, 2019
@pm3310
Copy link
Contributor

pm3310 commented Aug 31, 2019

Hey @ilazakis, I'm thinking to add the update endpoint functionality like this:

sagify cloud deploy -m s3://my-bucket/output/model.tar.gz -n 3 -e ml.m4.xlarge --endpoint-name my-endpoint --overwrite

Essentially, I'll add a new flag argument --overwrite that will require the --endpoint-name to be compulsory as we need to know which endpoint to update. What are your thoughts?

@pm3310 pm3310 self-assigned this Aug 31, 2019
@ilazakis
Copy link
Contributor Author

ilazakis commented Aug 31, 2019

Looks good @pm3310 . The only alternative I can think of at the moment is implicitly updating if the endpoint name already exists.

That is, if endoint-name is provided, check if an endpoint with that name exists; yes -> call SageMaker’s update config API(s), no -> create new endpoint.

This has the advantage of no new options being added and less work (I think) needed both for the PR and end users.

If I’m right, we would only need to make changes here and the docs.

@pm3310
Copy link
Contributor

pm3310 commented Aug 31, 2019

Gotcha! I'll follow your advice @ilazakis

@pm3310
Copy link
Contributor

pm3310 commented Oct 7, 2019

#95

@pm3310 pm3310 closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants