Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpublishing event is not registered and handled #64

Closed
Felwick opened this issue Aug 9, 2024 · 1 comment · Fixed by #65
Closed

Unpublishing event is not registered and handled #64

Felwick opened this issue Aug 9, 2024 · 1 comment · Fixed by #65

Comments

@Felwick
Copy link

Felwick commented Aug 9, 2024

Description:

Unpublished or archived pages are still part of the index content regardless of them being in unpublished state.

Reproduction steps:

  1. Create a page with unique name and information and publish it
  2. Search this page and confirm it is in the index
  3. Unpublish the page
  4. Check that the page can be still looked up in the index via search

Expected behavior:

Page should be removed from index by task when it is unpublished.

More details:

It seems that even though DefaultLuceneTaskLogger is expecting unpublish or archive events to come through in order to log tasks, LuceneSearchModule is only registering event delegate for these specific events:

    WebPageEvents.Publish.Execute += HandleEvent;
    WebPageEvents.Delete.Execute += HandleEvent;
    ContentItemEvents.Publish.Execute += HandleContentItemEvent;
    ContentItemEvents.Delete.Execute += HandleContentItemEvent;

Library Version

Kbank site on 7.0.1

@liparova
Copy link
Collaborator

liparova commented Aug 9, 2024

Thank you for bringing this to our attention. We will investigate and keep you informed of our progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants