Skip to content

Commit

Permalink
Fix providerless kubelet startup
Browse files Browse the repository at this point in the history
  • Loading branch information
liggitt committed Jul 31, 2020
1 parent 6324c13 commit 93e2868
Show file tree
Hide file tree
Showing 4 changed files with 58 additions and 3 deletions.
1 change: 1 addition & 0 deletions cmd/kubelet/app/options/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ go_library(
"globalflags.go",
"globalflags_linux.go",
"globalflags_other.go",
"globalflags_providers.go",
"options.go",
"osflags_others.go",
"osflags_windows.go",
Expand Down
4 changes: 1 addition & 3 deletions cmd/kubelet/app/options/globalflags.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,7 @@ func addCredentialProviderFlags(fs *pflag.FlagSet) {
global := pflag.CommandLine
local := pflag.NewFlagSet(os.Args[0], pflag.ExitOnError)

// TODO(#58034): This is not a static file, so it's not quite as straightforward as --google-json-key.
// We need to figure out how ACR users can dynamically provide pull credentials before we can deprecate this.
pflagRegister(global, local, "azure-container-registry-config")
addLegacyCloudProviderCredentialProviderFlags(global, local)

fs.AddFlagSet(local)
}
Expand Down
27 changes: 27 additions & 0 deletions cmd/kubelet/app/options/globalflags_providerless.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// +build providerless

/*
Copyright 2020 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package options

import (
"github.com/spf13/pflag"
)

func addLegacyCloudProviderCredentialProviderFlags(global, local *pflag.FlagSet) {
// no-op when no legacy providers are compiled in
}
29 changes: 29 additions & 0 deletions cmd/kubelet/app/options/globalflags_providers.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// +build !providerless

/*
Copyright 2020 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package options

import (
"github.com/spf13/pflag"
)

func addLegacyCloudProviderCredentialProviderFlags(global, local *pflag.FlagSet) {
// TODO(#58034): This is not a static file, so it's not quite as straightforward as --google-json-key.
// We need to figure out how ACR users can dynamically provide pull credentials before we can deprecate this.
pflagRegister(global, local, "azure-container-registry-config")
}

0 comments on commit 93e2868

Please sign in to comment.