Added Dropdown option , FIXES #367 #368
Conversation
✅ Deploy Preview for mogulchristmas ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
credits/index.html
Outdated
| <h3><a href="https://github.com/KendallDoesCoding/mogul-christmas/pull/291">Worked on the hyperlinks in JS for the "You May Like" directory for the "Pagination" update.</h3></a> | ||
|
|
||
| <div class="dropdown"> | ||
| <a href="https://github.com/KendallDoesCoding"><h1>KendallDoesCoding<button class="dropbtn"><i class="arrow down"></i></h1></a></button> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
credits/index.html
Outdated
|
|
||
|
|
||
| <div class="dropdown"> | ||
| <a href="https://github.com/TechStudent11"><h1>TechStudent10<button class="dropbtn"><i class="arrow down"></i></h1></a></button> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
credits/index.html
Outdated
|
|
||
|
|
||
| <div class="dropdown"> | ||
| <a href="https://github.com/aliraza944"><h1>Ali Raza<button class="dropbtn"><i class="arrow down"></i></h1></a></button> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
credits/index.html
Outdated
| </br> | ||
|
|
||
| <div class="dropdown"> | ||
| <a href="https://github.com/JeffBucherDev"><h1>JeffBucherDev<button class="dropbtn"><i class="arrow down"></i></h1></a></button> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
credits/index.html
Outdated
|
|
||
|
|
||
| <div class="dropdown"> | ||
| <a href="https://github.com/Bibhavshah"><h1>Bibhav Shah<button class="dropbtn"><i class="arrow down"></i></h1></a></button> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
credits/index.html
Outdated
| </br> | ||
|
|
||
| <div class="dropdown"> | ||
| <a href="https://github.com/Michael-Obele"><h1>Michael Obele<button class="dropbtn"><i class="arrow down"></i></h1></a></button> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
credits/index.html
Outdated
| </br> | ||
|
|
||
| <div class="dropdown"> | ||
| <a href="https://github.com/Weave-Trix"><h1>Weave-Trix<button class="dropbtn"><i class="arrow down"></i></h1></a></button> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
credits/index.html
Outdated
| </br> | ||
|
|
||
| <div class="dropdown"> | ||
| <a href="https://github.com/fk00750"><h1>F.K<button class="dropbtn"><i class="arrow down"></i></h1></a></button> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
credits/index.html
Outdated
|
|
||
|
|
||
| <div class="dropdown"> | ||
| <a href="https://github.com/ArhyaSaha"><h1>Arhya Saha<button class="dropbtn"><i class="arrow down"></i></h1></a></button> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
credits/index.html
Outdated
| </br> | ||
|
|
||
| <div class="dropdown"> | ||
| <a href="https://github.com/frazie"><h1>Frazier Odhiambo<button class="dropbtn"><i class="arrow down"></i></h1></a></button> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
|
i will try my best |
|
I have changed the styling of the arrow, please check that out |
can you not do this? |
|
@Cshiva773 - Thanks for the contribution! |
|
Thanks for merging my PR, I apologize for my action and I will make sure
that next time I will follow the guidelines
…On Sun, 9 Apr 2023 at 21:22, Kendall ***@***.***> wrote:
@Cshiva773 <https://github.com/Cshiva773> - Thanks for the contribution!
Please request to be assigned to a issue next time, before working on it.
—
Reply to this email directly, view it on GitHub
<#368 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AY72TJ5HGWFJ77KZKRPG7GTXALLKZANCNFSM6AAAAAAWXPRTAI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
🛠️ Fixes Issue
Related Issue/Addition to code
👨💻 Changes proposed
-Added Dropdown options in the contributor list to display their contributions in that dropdown list
Type of change
✔️ Check List (Check all the applicable boxes)
📷 Screenshots