Skip to content

Conversation

@berkus
Copy link
Contributor

@berkus berkus commented Oct 21, 2025

Fixes #978

@berkus
Copy link
Contributor Author

berkus commented Oct 22, 2025

@Keats if possible, this should be a non-breaking change. And will avoid the RUSTSEC hit for all downstreams.

@Keats
Copy link
Owner

Keats commented Oct 22, 2025

looks like we need to bump the CI msrv

@berkus
Copy link
Contributor Author

berkus commented Oct 22, 2025

Can do.

@Keats wouldn't MSRV bump be breaking though?

@Keats
Copy link
Owner

Keats commented Oct 22, 2025

No, it's basically impossible to keep a MSRV anyway

@berkus berkus force-pushed the fix-unic-dependency branch from 513e304 to 8784def Compare October 22, 2025 13:40
@berkus
Copy link
Contributor Author

berkus commented Oct 22, 2025

@Keats alright, bumped it, passes locally.

@Keats
Copy link
Owner

Keats commented Oct 25, 2025

looks like the embark actions need some updates. I think they don't use Rust anymore, is there another one?

@ralfbiedert
Copy link

ralfbiedert commented Oct 26, 2025

looks like the embark actions need some updates. I think they don't use Rust anymore, is there another one?

We use this here which if I understand correctly includes deny (and even zola as I just noticed :)

      - name: Install Cargo Tools
        uses: taiki-e/install-action@v2
        with:
          tool: cargo-deny

(Edit, you have to call cargo deny check then manually in a separate step)

@Keats
Copy link
Owner

Keats commented Oct 28, 2025

looks like we can switch to that

@berkus
Copy link
Contributor Author

berkus commented Oct 28, 2025

Lets try this

@berkus
Copy link
Contributor Author

berkus commented Oct 29, 2025

@Keats could you please press the button?

@berkus
Copy link
Contributor Author

berkus commented Oct 29, 2025

Looks good!

@Keats Keats merged commit bae8291 into Keats:master Oct 30, 2025
8 checks passed
@berkus berkus deleted the fix-unic-dependency branch October 30, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rustsec advisory flags tera via unic

3 participants