-
Notifications
You must be signed in to change notification settings - Fork 312
refactor: 📦 Replace unmaintained unic-segment dependency #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Keats if possible, this should be a non-breaking change. And will avoid the RUSTSEC hit for all downstreams. |
|
looks like we need to bump the CI msrv |
|
Can do. @Keats wouldn't MSRV bump be breaking though? |
Allow Unicode-3.0 OSI-approved license for unicode-segmentation.
|
No, it's basically impossible to keep a MSRV anyway |
513e304 to
8784def
Compare
|
@Keats alright, bumped it, passes locally. |
|
looks like the embark actions need some updates. I think they don't use Rust anymore, is there another one? |
We use this here which if I understand correctly includes deny (and even zola as I just noticed :) (Edit, you have to call |
|
looks like we can switch to that |
|
Lets try this |
|
@Keats could you please press the button? |
|
Looks good! |
Fixes #978