-
Notifications
You must be signed in to change notification settings - Fork 322
deserialization support for some missing algorithms #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2c80731
Only deserialization support for missing Algorithm (Keycloak)
nick9822 bf928a5
linting fixes
nick9822 f56f5d8
linting change leftover fix
nick9822 ae11655
KeyAlgorithm moved to mod jwk, typo fixes
nick9822 bec65e5
Moved pub method to Jwk private
nick9822 2eff256
Removed test
nick9822 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| use crate::errors::{Error, ErrorKind, Result}; | ||
| use crate::{ | ||
| errors::{Error, ErrorKind, Result}, | ||
| jwk::KeyAlgorithm, | ||
| }; | ||
| use serde::{Deserialize, Serialize}; | ||
| use std::str::FromStr; | ||
|
|
||
|
|
@@ -80,6 +83,11 @@ impl Algorithm { | |
| Algorithm::EdDSA => AlgorithmFamily::Ed, | ||
| } | ||
| } | ||
|
|
||
| /// Converting Key Algorithm to Algorithm | ||
| pub fn from_key_algorithm(s: &KeyAlgorithm) -> Result<Self> { | ||
| Algorithm::from_str(s.to_string().as_str()) | ||
| } | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
|
|
@@ -99,4 +107,19 @@ mod tests { | |
| assert!(Algorithm::from_str("PS512").is_ok()); | ||
| assert!(Algorithm::from_str("").is_err()); | ||
| } | ||
|
|
||
| #[test] | ||
| fn algorithm_inorder_keyalgorithm_check() { | ||
| let supported_algs = [ | ||
| "HS256", "HS384", "HS512", "ES256", "ES384", "RS256", "RS384", "PS256", "PS384", | ||
| "PS512", "RS512", "EdDSA", | ||
| ]; | ||
|
|
||
| for s in supported_algs { | ||
| assert!( | ||
| Algorithm::from_str(s).unwrap() as isize | ||
| == KeyAlgorithm::from_str(s).unwrap() as isize | ||
| ); | ||
| } | ||
| } | ||
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to do
KeyAlgorithm.to_algorithmsince this is not really meant to be public in practice and this way all the logic is contained in jwk.rs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I previously thought so but in the example
auth0.rsit neededAlgorithmfromKeyAlgorithmatValidation::new. I think we don't need public method just for that, we can do it viaAlgorithm::from_str