Skip to content

Conversation

@Hexilee
Copy link
Contributor

@Hexilee Hexilee commented Feb 27, 2020

I ran into #120 as well, so did a little changes.

@Keats
Copy link
Owner

Keats commented Feb 28, 2020

Thanks for that!
Can we remove the changes to 'static for now as it is a breaking change and only have the CoW + into_static? That would make it easier to use without a breaking change I think?

@Hexilee
Copy link
Contributor Author

Hexilee commented Feb 28, 2020

Of course, I reverted it.

@Hexilee
Copy link
Contributor Author

Hexilee commented Feb 29, 2020

Excuse me, but, can we merge this PR and publish a new version as soon as possible? I really need it.

@Keats
Copy link
Owner

Keats commented Feb 29, 2020

@MayaWolf and @tjwilson90 would this PR work for you?

@tjwilson90
Copy link

Yes, this looks good.

@MayaRainer
Copy link

I went for a different approach in my fork, where the DecodingKey and EncodingKey construction methods consume/move their parameters, which I think is the most versatile option - but that would be a breaking change, so if you're interested it's probably better to hold off until a major version bump.

@Keats
Copy link
Owner

Keats commented Mar 1, 2020

I think I prefer the approach of @Hexilee on that, making things Cow instead of owned so we don't need to clone when we can avoid it. That will be a change for the next version whenever it happens.

@Keats Keats merged commit d00d2f4 into Keats:master Mar 1, 2020
JadedBlueEyes referenced this pull request in JadedBlueEyes/jsonwebtoken Apr 13, 2023
fix issue 120: DecodingKey can be converted to static
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants