147 check if custom swarm controllers are needed #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oleschwen
commented
Nov 17, 2025
oleschwen
commented
- replaced usage of custom swarm client and server controllers by NVFlare controllers
- removed custom controllers
- removed corresponding unit tests
- added local openvpn container setup for manual testing
…ntainer branch, but without hard-coded certificates)
…g unit tests, use NVFlare controller classes instead
…d by the default server controller
3 tasks
…eded resolved conflict in buildDockerImageAndStartupKits.sh
…gain before merging to main)
…emoved again before merging to main)" This reverts commit e9c69d0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.