Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TetGen output capture and mesh quality warning system #222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

johannesring
Copy link
Collaborator

This PR adds basic parsing of TetGen’s terminal output in vmtkMeshGeneratorFsi to print warnings about potential mesh quality issues.

Some example thresholds (e.g. aspect ratio > 10) are used to trigger warnings, but these are not final — they’re just a starting point for discussion. No action is taken beyond logging.

Feedback on appropriate thresholds and how we should handle low-quality meshes is welcome.

Builds on the discussion in PR #219.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (6341898) to head (7de45d3).

Files with missing lines Patch % Lines
src/vasp/preprocessing/vmtkmeshgeneratorfsi.py 96.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   82.00%   82.14%   +0.13%     
==========================================
  Files          32       32              
  Lines        4013     4065      +52     
==========================================
+ Hits         3291     3339      +48     
- Misses        722      726       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants