Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kami considers itself as peer #41

Open
zemse opened this issue Jun 15, 2020 · 1 comment
Open

kami considers itself as peer #41

zemse opened this issue Jun 15, 2020 · 1 comment
Labels
bug Something isn't working priority Needs to closed ASAP

Comments

@zemse
Copy link
Contributor

zemse commented Jun 15, 2020

This can be solved by implementing public key / address in url that is shared. A peer address can be like this:

kami://c8e1f3b9a0cdfcef9ffd2343b943989a22517b26@192.168.0.143:15985

Using such url, a kami can identify that a particular peer of it's peer is the kami itself.

Also, kami needs to check finally if the signature matches the main address

@zemse zemse added the bug Something isn't working label Jun 15, 2020
@zemse zemse added the priority Needs to closed ASAP label Jul 9, 2020
@zemse
Copy link
Contributor Author

zemse commented Aug 1, 2020

Doing this will also fix MIM attack scope highlighted in #27. I think having address instead of public key should be fine, since address can be derived easily by hashing the public key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority Needs to closed ASAP
Projects
None yet
Development

No branches or pull requests

1 participant