Avoid False Positives Plugin: ArtifactoryDetector (Yelp#499)

gabrielsoltz · jpdakran · web-flow · commit 16cb91842b72 · 2022-10-04T09:45:44.000-04:00
* avoid_false_positives

* Add the option to end regex and or have whitespace and or have a quotation ending

Co-authored-by: John-Paul Dakran &lt;dakranj@yelp.com&gt;
diff --git a/detect_secrets/plugins/artifactory.py b/detect_secrets/plugins/artifactory.py
@@ -9,7 +9,7 @@ class ArtifactoryDetector(RegexBasedDetector):
 
     denylist = [
         # Artifactory tokens begin with AKC
-        re.compile(r'(?:\s|=|:|"|^)AKC[a-zA-Z0-9]{10,}'),  # API token
+        re.compile(r'(?:\s|=|:|"|^)AKC[a-zA-Z0-9]{10,}(?:\s|"|$)'),  # API token
         # Artifactory encrypted passwords begin with AP[A-Z]
-        re.compile(r'(?:\s|=|:|"|^)AP[\dABCDEF][a-zA-Z0-9]{8,}'),  # Password
+        re.compile(r'(?:\s|=|:|"|^)AP[\dABCDEF][a-zA-Z0-9]{8,}(?:\s|"|$)'),  # Password
     ]

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ class ArtifactoryDetector(RegexBasedDetector):`
`9`	`9`
`10`	`10`	`denylist = [`
`11`	`11`	`# Artifactory tokens begin with AKC`
`12`		`- re.compile(r'(?:\s\|=\|:\|"\|^)AKC[a-zA-Z0-9]{10,}'), # API token`
	`12`	`+ re.compile(r'(?:\s\|=\|:\|"\|^)AKC[a-zA-Z0-9]{10,}(?:\s\|"\|$)'), # API token`
`13`	`13`	`# Artifactory encrypted passwords begin with AP[A-Z]`
`14`		`- re.compile(r'(?:\s\|=\|:\|"\|^)AP[\dABCDEF][a-zA-Z0-9]{8,}'), # Password`
	`14`	`+ re.compile(r'(?:\s\|=\|:\|"\|^)AP[\dABCDEF][a-zA-Z0-9]{8,}(?:\s\|"\|$)'), # Password`
`15`	`15`	`]`