Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DISCUSSION] Add Caching for feeds #71

Open
rickyphewitt opened this issue Jan 21, 2017 · 2 comments
Open

[DISCUSSION] Add Caching for feeds #71

rickyphewitt opened this issue Jan 21, 2017 · 2 comments
Labels
Feature

Comments

@rickyphewitt
Copy link
Contributor

Placeholder issue to discuss and consider caching the feed xml files.

Things to consider:

  • Does caching the feeds make sense
  • How long to cache
  • What feeds to cache
  • Should this be a user configurable setting (default on/off)
@rickyphewitt
Copy link
Contributor Author

rickyphewitt commented Jan 21, 2017 •
edited
Loading

I'm not sure caching makes sense for feeds as it has the probability to introduce more issues than benefits.

Reason I'm adding it as an issue:

  • Caching has been mentioned in other issues
  • I have seen random url timouts when requesting feeds
  • If a user is browsing the app, selecting a show multiple times should not re-download the feed as (most likely) nothing has changed

Feel free to chime in :)

@RobLoach
Copy link
Contributor

Possibly cache feeds to <10 minutes so that browsing experience is quick, but we still have recent content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobLoach @rickyphewitt