Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration without groups #43

Open
crislub opened this issue Jul 11, 2023 · 4 comments
Open

Configuration without groups #43

crislub opened this issue Jul 11, 2023 · 4 comments

Comments

@crislub
Copy link

crislub commented Jul 11, 2023

Hi,

I am starting to create a new terraform setup for Juniper devices. When I started to test the the code I see that it is by groups. Is there any way to do it without these?

For example I have a description in ge-0/0/0 which is "My description" and when I try to modify it via terraform it creates a new group with a "New description" description but doesn't override the current information.

This is an easy test but I am worried in the future about going through the code manually when we run into a problem. it's a bit complex with groups instead of directly modify the option.

@vinpatel24
Copy link
Collaborator

This approach simplifies the implementation of the terraform providers by taking advantage of the JUNOS apply-groups feature. In order to implement a different approach we would have to parse the YANG schema locally and perform an XML merge locally. This is a significant effort but we may have to do it this way for efficiency reasons. For now, you can see the resulting config by using the command: show configuration | display inheritance no-comments

@a-chartier
Copy link
Contributor

a-chartier commented Jul 27, 2023

@vinpatel24

This is actually something we have done internally by forking and modifying this generator. I am just trying to find cycles to contribute everything else up stream here.

I have also moved everything to a pure go implementation from a generation aspect and making use of go-templates for everything.

If i can find some cycles in the next few weeks i should be able to push something up. When I was bench-marking this I think it was about 60,000 changes with a full commit check in around 1.5 min.

@vinpatel24
Copy link
Collaborator

Hi @a-chartier,

I am very glad to see that you have been able to work on this type of approach and I look forward to seeing what changes you are able to contribute.

@davisonja
Copy link

That would be a fantastic update @a-chartier
My current problem with the groups is that they don't always seem to be reflected in the web-ui - address book entries are effectively added with the groups (show configuration | display inheritance no-comments shows them, and they work in, say NAT rules) but they are not shown in the plain address book (show security address-book or the web UI address book page)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants