Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able to disable EOS for xpaths in preGNMI mode #38

Open
xp600 opened this issue Jun 6, 2024 · 4 comments
Open

Need to be able to disable EOS for xpaths in preGNMI mode #38

xp600 opened this issue Jun 6, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@xp600
Copy link

xp600 commented Jun 6, 2024

With EOS enabled, subscriptions to xpaths in preGNMI mode cause Init Sync packets to be sent.

Google does not fetch initial sync data for preGNMI sensors.

To be consistent with the google collectors, we need the jtimon team to provide option to turn off init sync for pre-GNMI sessions.

@M-Vivek-Juniper , @amohit1315

@amohit1315
Copy link
Collaborator

Hey @xp600 , do we need it enabled for GNMI and disable it for pre-GNMI, when EOS is explicitly configured in the jtimon configuration

@xp600
Copy link
Author

xp600 commented Jun 11, 2024

Hi @amohit1315, We need the flexibility to configure (enable/disable) EOS individually for preGNMI and GNMI xpaths please.

@amohit1315
Copy link
Collaborator

Added config for enabling/disabling eos for internal jtimon configs.
This configuration overrides the eos value set outside the internal-jtimon config section

Example:

"internal-jtimon": {
    "data-log-file": "TelemetrySensorData.log",
    "gnmi-eos": true,
    "pre-gnmi-eos": true
}

If not set within internal-jtimon, then this is set to false by default.
Note: if EOS is enabled in main config and internal-jtimon is also configured, then eos will be set to default if eos is not configured in internal-jtimon

@amohit1315
Copy link
Collaborator

Will move the ticket back, once the changes are approved and merged

@amohit1315 amohit1315 self-assigned this Jun 20, 2024
@amohit1315 amohit1315 added the enhancement New feature or request label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants