Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos for PRE and POST keys in the node_value_passed of not_exists operator #410

Closed
quangtamle opened this issue May 3, 2024 · 2 comments
Assignees
Labels

Comments

@quangtamle
Copy link

Description of Issue/Question

According to the code:

PRE and POST keys in the node_value_passed dict of not_exists operator are capitalized which are not synchronized (should be in small letters like the others)

I wonder whether those capital keys are on purpose or not. If not, can we fix those to small letters for unified format of node_value_passed dict ?

Setup

(Please provide relevant configs, xml snapshots and related files (Be sure to remove sensitive info).)
No need

Steps to Reproduce Issue

(Include debug logs if possible and relevant. Error trace would be helpful too)
No need

Versions Report

(Provided by running jsnapy --version. Please also mention python version.)
the current version

@chidanandpujar
Copy link
Collaborator

Fix is under review #414

@chidanandpujar chidanandpujar self-assigned this Jun 11, 2024
@chidanandpujar
Copy link
Collaborator

Fixed via #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants