feat: add domain attribute in routes registry#88
Draft
densetsuuu wants to merge 2 commits intoJulien-R44:nextfrom
Draft
feat: add domain attribute in routes registry#88densetsuuu wants to merge 2 commits intoJulien-R44:nextfrom
densetsuuu wants to merge 2 commits intoJulien-R44:nextfrom
Conversation
Contributor
Author
|
Sorry @Julien-R44, the PR is a little bit bloated because I had to update the fixtures and scripts too ahah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
domainproperty to route definitionsCloses #85
Summary
This change adds the
domainproperty to the generated route registry and theAdonisEndpointtype, allowing Tuyau to be aware of which domain each route belongs to (e.g.'root','api', etc.).Testing
api.v1.testetest fixture withdomain: 'api'to cover non-root domain routesClient | Registry domaintest group with two cases:'api')'root'Aim
Previously, all routes were treated as belonging to the
'root'domain regardless of their actual AdonisJS domain configuration. This made it impossible to distinguish routes defined under different domains (e.g.router.group(() => { ... }).domain('api')). With this change, the domain information flows through from AdonisJS route scanning to the generated registry and into the client, enabling domain-aware route resolution.