Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid call to validateattrs #15

Closed
kskyten opened this issue Jun 8, 2019 · 8 comments
Closed

Invalid call to validateattrs #15

kskyten opened this issue Jun 8, 2019 · 8 comments

Comments

@kskyten
Copy link

kskyten commented Jun 8, 2019

Running

using Hyperscript
m("div")

raises the following error on the current version in the package registry:

ERROR: MethodError: no method matching validateattrs(::Hyperscript.Validate{true}, ::String, ::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}})
Closest candidates are:
validateattrs(::Hyperscript.Validate, ::Any, ::NamedTuple) at ~/.julia/packages/Hyperscript/qO5ub/src/Hyperscript.jl:80
validateattrs(::Hyperscript.NoValidate, ::Any, ::NamedTuple) at ~/.julia/packages/Hyperscript/qO5ub/src/Hyperscript.jl:94
Stacktrace:
[1] Hyperscript.Node(::Hyperscript.Validate{true}, ::String, ::Tuple{}, ::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at ~/.julia/packages/Hyperscript/qO5ub/src/Hyperscript.jl:111
[2] #m#7(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::String) at ~/.julia/packages/Hyperscript/qO5ub/src/Hyperscript.jl:174
[3] m(::String) at ~/.julia/packages/Hyperscript/qO5ub/src/Hyperscript.jl:174
[4] top-level scope at none:0
@yurivish
Copy link
Collaborator

yurivish commented Jun 8, 2019

Hi, can you see if this happens using the master branch? It may be that the latest version just wants a proper release — I haven’t made one since Julia 1.0, I think.

@kskyten
Copy link
Author

kskyten commented Jun 8, 2019

Seems to be working in master.

@SimonDanisch
Copy link
Collaborator

Yes, can we make a new release? :) We're at 375 commits to master since this release ;)

@yurivish
Copy link
Collaborator

yurivish commented Jul 2, 2019

Poke me in a few weeks when I have a little more time — we should make a new release. :)

@SimonDanisch
Copy link
Collaborator

To you want to transfer it to an org we both have access to? I could make a release, if you want

@yurivish
Copy link
Collaborator

yurivish commented Jul 3, 2019

I just added you as a collaborator to this repository. Does that give you adequate permissions to make a release?

@SimonDanisch
Copy link
Collaborator

Let's try ;)

@yurivish
Copy link
Collaborator

Thanks for the release. I'm closing this issue now since the fix has been deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants