-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logo #128
Update logo #128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 76.80% 76.80%
=======================================
Files 11 11
Lines 763 763
=======================================
Hits 586 586
Misses 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nice!! |
I personally prefer the non-transparent of the logo slightly, but in the end, I am fine either way. Perhaps @lgoettgens has a preference? Anyway, I am also happy to merge-as is, as I think this is an improvement either way. Thank you! |
I like the non-transparent more as well, but no strong preference. |
Thank you for the suggestions on the logo. I will update the logo design tomorrow, so please wait until then to merge this PR😀. |
I feel it's better without double outline.🤓 |
I like no stroke or documenter white |
This needs a rebase. And I really have no real preference, but like the "documenter white" one a bit more |
Okay, I'll update this PR with documenter-white. 👍 |
Please have a look at the code-style CI job and try to make it happy :) |
I think the format suggestion from the bot can be improved like in ChainRulesCore.jl. (JuliaDiff/ChainRulesCore.jl#626 (comment)) Can I open a PR for that? |
Yeah, of course. It would be great to have that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The look is fine. Some technical comments
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Thank you for the review & merge! |
Thank You for the effort in this PR! |
This PR adds the logo to the documentation page, and updates the
Makefile
.x-ref: #119 (comment)