-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exponential weights #401
Conversation
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
+ Coverage 83.99% 90.07% +6.08%
==========================================
Files 21 21
Lines 2162 2026 -136
==========================================
+ Hits 1816 1825 +9
+ Misses 346 201 -145
Continue to review full report at Codecov.
|
8719310
to
a0b7417
Compare
I've pared this down to remove the automatic normalization and I've deleted the variance correction method (so exponential weights will fall back to the generic definition which produces an error), corrected the language used in the documentation, removed the |
Bump |
Still need to address https://github.com/JuliaStats/StatsBase.jl/pull/401/files#r214542378 |
@ararslan Are you okay if I update your branch? |
Yes, please do! |
Co-authored-by: Alex Arslan <ararslan@comcast.net>
245409f
to
7482a38
Compare
7482a38
to
f701581
Compare
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
Okay, apart from your comments around the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few last remarks and I think it's good!
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
I guess if nobody has any other comments then I'll merge it tomorrow. |
Thanks for getting this finished up, Rory. :) |
This is almost entirely code written by @rofinn. I'm just submitting it here with a couple of slight modifications.