Replace AbstractTriangular by UpperOrLowerTriangular #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #329 +/- ##
==========================================
- Coverage 93.68% 93.65% -0.03%
==========================================
Files 12 12
Lines 7454 7454
==========================================
- Hits 6983 6981 -2
- Misses 471 473 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
Any objections? Does anybody know about custom |
Member
|
No objection from me. seems fine to merge. |
ViralBShah
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to push JuliaLang/julia#26307 across the finish line. I don't think the intention here was really
AbstractTriangular, but that the intention was to refer to the LinAlg types, which is exactly whatUpperOrLowerTriangularis referring to.