Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Base.Lockable #31

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Prepare for Base.Lockable #31

merged 1 commit into from
Feb 8, 2024

Conversation

vtjnash
Copy link
Contributor

@vtjnash vtjnash commented Feb 6, 2024

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e06acf) 89.86% compared to head (52c748e) 89.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files           8        8           
  Lines         365      365           
=======================================
  Hits          328      328           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinnj quinnj merged commit e30584c into JuliaServices:main Feb 8, 2024
6 checks passed
@ericphanson
Copy link

IIRC the only difference between the Lockable in this repo and the one in Base is that the one in Base does an assert_haslock when you getindex to access the value. I could see that breaking code (maybe in tests or whatever that isn't necessarily being careful). So just wanted to call out that potential gotcha here, since folks might get unexpected errors when updating to v1.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants