Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we store assets in a different repository? #142

Open
Sid-Bhatia-0 opened this issue Jun 7, 2021 · 2 comments
Open

Should we store assets in a different repository? #142

Sid-Bhatia-0 opened this issue Jun 7, 2021 · 2 comments

Comments

@Sid-Bhatia-0
Copy link
Member

@findmyway

The total repo size of GridWorlds.jl is already around 55MB.
I was wondering if we should store assets in a different repository GridWorldsAssets and only use links in this repository. I understand that this might not be a very good practice in general. It is likely that we will add and modify the gifs in the future. And as the number of environments increases, modifications become costly for gifs.

It would be nice to freely experiment with different images & gifs, and not worry about the repo size drastically increasing.

@findmyway
Copy link
Member

findmyway commented Jun 8, 2021

empty_room_directed

Or maybe simply upload the image to github and use the generated link instead?
(We'd better clean up the uploaded gif. 55M is way too large for this project.)

@Sid-Bhatia-0
Copy link
Member Author

Or maybe simply upload the image to github and use the generated link instead?

Good idea! We can have dedicated issues for uploading assets corresponding to each environment.

And once I finish doing this for all the current assets, we can use a tool like https://rtyley.github.io/bfg-repo-cleaner/ to delete those assets from the git history to significantly reduce the repo size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants