-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing support #265
Comments
Yeah I think that makes sense to me. What do you think the right approach to that would be? Right now we lean on how JSON.jl wants to serialize things and define a few methods for JSON.lower here. I don't think we should be type pirates and define |
@TotalVerb We'd like to serialize (write) |
JSON.jl already serializes It's possible this has not been tagged. I'll check this. Edit: No, it should be in 0.20.0. |
I believe the issue is that one of the JSON.lower overrides is calling JSON.lower before returning the result, which is not the intended usage. Please see #266 for a solution. |
Thanks @TotalVerb! @cstjean I just tried your example with the latest master of PlotlyJS.jl (doesn't include #266) and the code snippet you posted above and it works for me without any modification needed... What version of JSON.jl and julia do you have? What about your OS (though I can't imagine why that would matter for this issue)? |
Right, #266 will have no effect if |
I can't check right now, but I assume that I just had a lower JSON version installed because of some upper-bound somewhere. Thank you for your help both! |
ok sounds good, if you check and it it still an issue please reopen. Thanks |
yields
Cannot serialize type Missing
. I think it would be OK to convert them toNaN
? That's whatPlots.jl
does IIRC.The text was updated successfully, but these errors were encountered: