Add cispi and sincospi (#533)

Author: giordano

src/quantities.jl

@@ -206,8 +206,10 @@ sqrt(x::AbstractQuantity) = Quantity(sqrt(x.val), sqrt(unit(x)))
 cbrt(x::AbstractQuantity) = Quantity(cbrt(x.val), cbrt(unit(x)))
 
 for _y in (:sin, :cos, :tan, :asin, :acos, :atan, :sinh, :cosh, :tanh, :asinh, :acosh, :atanh,
-           :sinpi, :cospi, :sinc, :cosc, :cis)
-    @eval ($_y)(x::DimensionlessQuantity) = ($_y)(uconvert(NoUnits, x))
+           :sinpi, :cospi, :sinc, :cosc, :cis, :cispi, :sincospi)
+    if isdefined(Base, _y)
+        @eval Base.$(_y)(x::DimensionlessQuantity) = Base.$(_y)(uconvert(NoUnits, x))
+    end
 end
 
 atan(y::AbstractQuantity{T1,D,U1}, x::AbstractQuantity{T2,D,U2}) where {T1,T2,D,U1,U2} =

test/runtests.jl

@@ -710,6 +710,12 @@ end
         @test @inferred(cospi(1rad)) == -1
         @test @inferred(sinc(1rad)) === 0
         @test @inferred(cosc(1ft/3inch)) === 0.25
+        if isdefined(Base, :cispi)
+            @test @inferred(cispi(rad/2)) === complex(0.0, 1.0)
+        end
+        if isdefined(Base, :sincospi)
+            @test @inferred(sincospi(rad/2)) === (1.0, 0.0)
+        end
 
         @test @inferred(atan(m*sqrt(3),1m)) ≈ 60°
         @test @inferred(atan(m*sqrt(3),1.0m)) ≈ 60°