From cd06f8c1863d1f90faa1ba2770c386ca1058e061 Mon Sep 17 00:00:00 2001 From: Jan Weidner Date: Fri, 1 Jul 2022 17:27:53 +0200 Subject: [PATCH] remove codecov --- .github/workflows/CI.yml | 5 ----- README.md | 1 - src/ConstructionBase.jl | 11 ++--------- 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 7c14f88..d2be379 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -33,8 +33,3 @@ jobs: arch: ${{ matrix.arch }} - uses: julia-actions/julia-buildpkg@latest - uses: julia-actions/julia-runtest@latest - - uses: julia-actions/julia-processcoverage@v1 - - uses: codecov/codecov-action@v1 - with: - file: lcov.info - fail_ci_if_error: true diff --git a/README.md b/README.md index 3ad6f61..f624da6 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,6 @@ [![Stable](https://img.shields.io/badge/docs-stable-blue.svg)](https://JuliaObjects.github.io/ConstructionBase.jl/stable) [![Dev](https://img.shields.io/badge/docs-dev-blue.svg)](https://JuliaObjects.github.io/ConstructionBase.jl/dev) [![Build Status](https://github.com/JuliaObjects/ConstructionBase.jl/workflows/CI/badge.svg)](https://github.com/JuliaObjects/ConstructionBase.jl/actions?query=workflow%3ACI) -[![Codecov](https://codecov.io/gh/JuliaObjects/ConstructionBase.jl/branch/master/graph/badge.svg)](https://codecov.io/gh/JuliaObjects/ConstructionBase.jl) [![GitHub stars](https://img.shields.io/github/stars/JuliaObjects/ConstructionBase.jl?style=social)](https://github.com/JuliaObjects/ConstructionBase.jl) ConstructionBase is a very lightwight package, that provides primitive functions for construction of objects: diff --git a/src/ConstructionBase.jl b/src/ConstructionBase.jl index 3c483d9..86a7be4 100644 --- a/src/ConstructionBase.jl +++ b/src/ConstructionBase.jl @@ -184,20 +184,13 @@ end setproperties_object(obj, patch::NamedTuple{()}) = obj function setproperties_object(obj, patch) - check_properties_are_fields_except_old_julia(obj)::Nothing + check_properties_are_fields(obj) nt = getproperties(obj) nt_new = merge(nt, patch) - check_patch_properties_exist(nt_new, nt, obj, patch)::Nothing + check_patch_properties_exist(nt_new, nt, obj, patch) args = Tuple(nt_new) # old julia inference prefers if we wrap in Tuple constructorof(typeof(obj))(args...) end -if VERSION < v"1.3" - # on old julia versions check_properties_are_fields - # trips inference of setproperties - check_properties_are_fields_except_old_julia(_) = nothing -else - check_properties_are_fields_except_old_julia(obj) = check_properties_are_fields(obj) -end include("nonstandard.jl") include("functions.jl")