Avoid an infinite loop in beta_inc for NaN input
#445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows suit with `gamma_inc`, which returns `NaN` if either of its two arguments are `NaN`, by returning `NaN` if any of the four arguments are `NaN`.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #445 +/- ##
=======================================
Coverage 94.32% 94.33%
=======================================
Files 14 14
Lines 2909 2911 +2
=======================================
+ Hits 2744 2746 +2
Misses 165 165
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows suit with
gamma_inc, which returnsNaNif either of its two arguments areNaN, by returningNaNif any of the four arguments areNaN.See JuliaStats/GLM.jl#538